From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: 2.4.0-pre10: svclock: missing unlock_kernel()
Date: Wed, 1 Nov 2000 13:04:55 +0100 (CET) [thread overview]
Message-ID: <14848.1767.586244.448799@charged.uio.no> (raw)
Linus,
I missed a conditional return in nlmsvc_notify_blocked() when we
should be releasing the BKL. Thanks to Jim Castleberry for pointing it
out.
Please note, however, that there remain serious bugs in 2.4.0-pre10
fs/locks.c w.r.t. notification of the filesystem/lockd that need to be
fixed before the 2.4.0 release.
Cheers,
Trond
--- fs/lockd/svclock.c.orig Tue Oct 31 00:31:49 2000
+++ fs/lockd/svclock.c Wed Nov 1 12:57:25 2000
@@ -473,6 +473,7 @@
if (nlm_compare_locks(&block->b_call.a_args.lock.fl, fl)) {
nlmsvc_insert_block(block, 0);
svc_wake_up(block->b_daemon);
+ unlock_kernel();
return;
}
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
reply other threads:[~2000-11-01 12:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14848.1767.586244.448799@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).