linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@osdl.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 5/5] netpoll: interface cleanup
Date: Mon, 23 Oct 2006 12:04:37 -0700	[thread overview]
Message-ID: <20061023120437.1731d817@dxpl.pdx.osdl.net> (raw)
In-Reply-To: <20061023120253.5dd146d2@dxpl.pdx.osdl.net>

Trivial cleanup of netpoll interface. Use constants
for size, to make usage clear.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>

--- netpoll.orig/include/linux/netpoll.h
+++ netpoll/include/linux/netpoll.h
@@ -12,15 +12,14 @@
 #include <linux/rcupdate.h>
 #include <linux/list.h>
 
-struct netpoll;
-
 struct netpoll {
 	struct net_device *dev;
-	char dev_name[16], *name;
+	char dev_name[IFNAMSIZ];
+	const char *name;
 	void (*rx_hook)(struct netpoll *, int, char *, int);
 	u32 local_ip, remote_ip;
 	u16 local_port, remote_port;
-	unsigned char local_mac[6], remote_mac[6];
+	u8 local_mac[ETH_ALEN], remote_mac[ETH_ALEN];
 };
 
 struct netpoll_info {

  reply	other threads:[~2006-10-23 19:05 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-19 17:15 [PATCH 0/3] netpoll/netconsole fixes Stephen Hemminger
2006-10-19 17:15 ` [PATCH 1/3] netpoll: initialize skb for UDP Stephen Hemminger
2006-10-20  6:58   ` David Miller
2006-10-19 17:15 ` [PATCH 2/3] netpoll: rework skb transmit queue Stephen Hemminger
2006-10-20  7:15   ` David Miller
2006-10-20 15:18     ` Stephen Hemminger
2006-10-20 19:24       ` David Miller
2006-10-20 19:25         ` Stephen Hemminger
2006-10-20 19:52           ` David Miller
2006-10-20 20:14             ` Stephen Hemminger
2006-10-20 20:25             ` Stephen Hemminger
2006-10-21  5:00               ` Dave Jones
2006-10-21  6:38                 ` David Miller
2006-10-20 15:40     ` Stephen Hemminger
2006-10-20 19:27       ` David Miller
2006-10-20 19:31         ` Stephen Hemminger
2006-10-20 20:42       ` David Miller
2006-10-20 20:48         ` Stephen Hemminger
2006-10-20 21:01           ` Andi Kleen
2006-10-20 21:08             ` David Miller
2006-10-20 21:16               ` Andi Kleen
2006-10-20 21:41                 ` Stephen Hemminger
2006-10-20 21:01           ` David Miller
2006-10-20 22:30             ` [PATCH 1/3] netpoll: use sk_buff_head for txq Stephen Hemminger
2006-10-23  3:42               ` David Miller
2006-10-23 19:02                 ` [PATCH 1/5] " Stephen Hemminger
2006-10-23 19:04                   ` Stephen Hemminger [this message]
2006-10-24  6:03                   ` David Miller
2006-10-24 14:51                     ` Stephen Hemminger
2006-10-24 14:14                       ` Stephen Hemminger
     [not found]                 ` <20061023115111.0d69846e@dxpl.pdx.osdl.net>
2006-10-23 19:02                   ` [PATCH 2/5] netpoll: cleanup queued transmit Stephen Hemminger
     [not found]                 ` <20061023115337.1f636ffb@dxpl.pdx.osdl.net>
2006-10-23 19:02                   ` [PATCH 4/5] netpoll: move drop hook inline Stephen Hemminger
2006-10-23 19:03                   ` [PATCH 3/5] netpoll: cleanup transmit retry logic Stephen Hemminger
2006-10-20 22:32             ` [PATCH 2/3] netpoll: use device xmit directly Stephen Hemminger
2006-10-20 22:35             ` [PATCH 3/3] netpoll: retry logic cleanup Stephen Hemminger
2006-10-19 17:15 ` [PATCH 3/3] netpoll: use skb_buff_head for skb cache Stephen Hemminger
2006-10-20  6:57 ` [PATCH 0/3] netpoll/netconsole fixes Andrew Morton
2006-10-20  7:16   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061023120437.1731d817@dxpl.pdx.osdl.net \
    --to=shemminger@osdl.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).