From: Shardar Shariff Md <smohammed@nvidia.com>
To: <ldewangan@nvidia.com>, <vinod.koul@intel.com>,
<dan.j.williams@intel.com>, <swarren@wwwdotorg.org>,
<thierry.reding@gmail.com>, <gnurou@gmail.com>,
<dmaengine@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <jonathanh@nvidia.com>
Cc: <smohammed@nvidia.com>
Subject: [PATCH] dmaengine: tegra: crash fix observed during dma client(UART) stress testing
Date: Tue, 3 May 2016 17:44:58 +0530 [thread overview]
Message-ID: <1462277698-11360-1-git-send-email-smohammed@nvidia.com> (raw)
During DMA client(UART) stress testing, observed below crash:
[ 167.041591] Unable to handle kernel paging request at virtual address 00100108
[ 167.048818] pgd = ffffffc0de7ee000
[ 167.052222] [00100108] *pgd=0000000000000000
[ 167.056513] Internal error: Oops: 96000045 [#1] PREEMPT SMP
[ 167.084048] Modules linked in:
[ 167.087126] CPU: 0 PID: 1786 Comm: uarttest Tainted: G W 3.10.33-gb76f6f9 #5
[ 167.095040] task: ffffffc0a5ba6ac0 ti: ffffffc094380000 task.ti: ffffffc094380000
[ 167.102529] PC is at tegra_dma_tasklet+0x50/0xf4
[ 167.107148] LR is at tegra_dma_tasklet+0xc0/0xf4
[ 167.111767] pc : [<ffffffc00044acc8>] lr : [<ffffffc00044ad38>] pstate: 800001c5
[ 167.119155] sp : ffffffc094383a60
[ 167.122469] x29: ffffffc094383a60 x28: 0000000000000000
Issue: UART RX channel DMA completion EOC(End of completion) interrupt
occurs and dma driver schedules tasklet() to execute callback function
and empty the cb_desc (callback descriptor). Before dma driver tasklet
runs, UART RX EORD (end of receive data) interrupt occurs. Here UART RX
ISR handler calls tegra_dma_terminate_all() and re-configures the DMA
for RX. While re-configuring, the cb_node data is re-initialized but the
cb_desc list is not emptied. Now when dma driver tasklet callback function
tries to check cb_desc and delete the cb_node (re-initialized node) kernel
crashes.
Fix: Empty the cb_desc data structure during tegra_dma_terminate_all()
routine if there are no pending transfers.
Signed-off-by: Shardar Shariff Md <smohammed@nvidia.com>
---
drivers/dma/tegra20-apb-dma.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index 3871f29..34bb4cd 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -751,10 +751,8 @@ static int tegra_dma_terminate_all(struct dma_chan *dc)
bool was_busy;
spin_lock_irqsave(&tdc->lock, flags);
- if (list_empty(&tdc->pending_sg_req)) {
- spin_unlock_irqrestore(&tdc->lock, flags);
- return 0;
- }
+ if (list_empty(&tdc->pending_sg_req))
+ goto empty_cblist;
if (!tdc->busy)
goto skip_dma_stop;
@@ -787,6 +785,7 @@ static int tegra_dma_terminate_all(struct dma_chan *dc)
skip_dma_stop:
tegra_dma_abort_all(tdc);
+empty_cblist:
while (!list_empty(&tdc->cb_desc)) {
dma_desc = list_first_entry(&tdc->cb_desc,
typeof(*dma_desc), cb_node);
--
1.8.1.5
next reply other threads:[~2016-05-03 12:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 12:14 Shardar Shariff Md [this message]
2016-05-03 14:09 ` [PATCH] dmaengine: tegra: crash fix observed during dma client(UART) stress testing Jon Hunter
2016-05-03 14:44 ` Shardar Mohammed
2016-05-03 15:17 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462277698-11360-1-git-send-email-smohammed@nvidia.com \
--to=smohammed@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).