From: Jim Studt <jim@federated.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] tulip oops for some eeproms in 2.4.0-test10
Date: Wed, 1 Nov 2000 14:45:06 -0600 (CST) [thread overview]
Message-ID: <200011012045.OAA08574@core.federated.com> (raw)
(please cc me, I follow the list on a web page)
The printk()s which enumerate media types during boot will oops
for some eeproms. They use the media type as an index into an
array of strings without doing any bounds checking.
This patch fixes it. The leaf->type is the killer for my card, I
have a descriptor where that is 128, the block_name table only has 6
entries. (The card is a Lite-On Communications Inc LNE100TX, based
on a Kingston card. Freebie from SWBell on DSL install.)
The "leaf->media & 0x0f" range check is sufficient, but not as nice
as the explicit size check on leaf->type. There are 16 entires in
medianame, but that is not known to this file during compilation.
(leaf->media could be as high as 0x3f, so some sort of check is called for.
If anyone named linus asks me to make a patch that uses the real size
of medianame I will. :-)
--- linux/drivers/net/tulip/eeprom.c.orig Wed Nov 1 14:32:18 2000
+++ linux/drivers/net/tulip/eeprom.c Wed Nov 1 14:14:02 2000
@@ -236,8 +236,9 @@
}
printk(KERN_INFO "%s: Index #%d - Media %s (#%d) described "
"by a %s (%d) block.\n",
- dev->name, i, medianame[leaf->media], leaf->media,
- block_name[leaf->type], leaf->type);
+ dev->name, i, medianame[leaf->media & 0x0f], leaf->media,
+ ((leaf->type < sizeof(block_name)/sizeof(block_name[0])) ? block_name[leaf->type] : "unknown"),
+ leaf->type);
}
if (new_advertise)
tp->to_advertise = new_advertise;
--
Jim Studt, President
The Federated Software Group, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
reply other threads:[~2000-11-01 20:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200011012045.OAA08574@core.federated.com \
--to=jim@federated.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).