linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lightweight patch manager <patch@luckynet.dynu.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@transmeta.com>
Subject: [PATCH][2.5] Port opl3sa2 changes from 2.4
Date: Mon, 3 Jun 2002 16:32:58 -0600 (MDT)	[thread overview]
Message-ID: <Pine.LNX.4.44.0206031628050.11309-100000@hawkeye.luckynet.adm> (raw)

opl3sa2 didn't accept dma=0 in 2.4 due to isapnp

In a recent thread [1], someone described problems with opl3sa2 on 
Linux-2.4 when dma 0 was used, since isapnp didn't support dma 0. If it's 
necessary to patch this in Linux-2.5 either, please apply this one. 

[1] <URL:http://marc.theaimsgroup.com/?l=linux-kernel&m=102310599324992&w=2>

--- linus-2.5/sound/oss/opl3sa2.c	Mon Jun  3 06:32:51 2002
+++ thunder-2.5.20/sound/oss/opl3sa2.c	Mon Jun  3 16:26:38 2002
@@ -874,8 +874,18 @@
 		opl3sa2_activated[card] = 1;
 	}
 	else {
+		/*
+		 * isapnp.c disallows dma=0, but the opl3sa2 card itself
+		 * accepts this value perfectly.
+		 */
+		if (dev->ro) {
+			isapnp_resource_change(&dev->dma_resource[0], 0, 1);
+			isapnp_resource_change(&dev->dma_resource[1], 1, 1);
+		}
+		opl3sa2_state[card].activated = 1;
+
 		if(dev->activate(dev) < 0) {
-			printk(KERN_WARNING "opl3sa2: ISA PnP activate failed\n");
+			printk(KERN_WARNING "opl3sa2: ISA PnP activate failed!\n");
 			opl3sa2_activated[card] = 0;
 			return -ENODEV;
 		}
-- 
Lightweight patch manager using pine. If you have any objections, tell me.


             reply	other threads:[~2002-06-03 22:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-03 22:32 Lightweight patch manager [this message]
2002-06-03 23:00 ` [PATCH][2.5] Port opl3sa2 changes from 2.4 Scott Murray
2002-06-03 23:11   ` Thunder from the hill
2002-06-03 23:50     ` Scott Murray
2002-06-03 23:56       ` Thunder from the hill
2002-06-04 12:35     ` Zwane Mwaikambo
2002-06-04 12:31   ` Zwane Mwaikambo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0206031628050.11309-100000@hawkeye.luckynet.adm \
    --to=patch@luckynet.dynu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).