From: Omar Sandoval <osandov@osandov.com>
To: Jens Axboe <axboe@fb.com>, linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
Alexei Starovoitov <ast@fb.com>
Subject: [PATCH v3 2/5] sbitmap: allocate wait queues on a specific node
Date: Fri, 9 Sep 2016 11:42:08 -0700 [thread overview]
Message-ID: <ab0ffdba530d6dffb86c47745c2976a9be53dd5d.1473446095.git.osandov@fb.com> (raw)
In-Reply-To: <cover.1473446095.git.osandov@fb.com>
In-Reply-To: <cover.1473446095.git.osandov@fb.com>
From: Omar Sandoval <osandov@fb.com>
The original bt_alloc() we converted from was using kzalloc(), not
kzalloc_node(), to allocate the wait queues. This was probably an
oversight, so fix it for sbitmap_queue_init_node().
Signed-off-by: Omar Sandoval <osandov@fb.com>
---
lib/sbitmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/sbitmap.c b/lib/sbitmap.c
index 303d83e..213d831 100644
--- a/lib/sbitmap.c
+++ b/lib/sbitmap.c
@@ -208,7 +208,7 @@ int sbitmap_queue_init_node(struct sbitmap_queue *sbq, unsigned int depth,
atomic_set(&sbq->wake_index, 0);
- sbq->ws = kzalloc(SBQ_WAIT_QUEUES * sizeof(*sbq->ws), flags);
+ sbq->ws = kzalloc_node(SBQ_WAIT_QUEUES * sizeof(*sbq->ws), flags, node);
if (!sbq->ws) {
sbitmap_free(&sbq->sb);
return -ENOMEM;
--
2.9.3
next prev parent reply other threads:[~2016-09-09 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 18:42 [PATCH v3 0/5] blk-mq: abstract tag allocation out into sbitmap library Omar Sandoval
2016-09-09 18:42 ` [PATCH v3 1/5] " Omar Sandoval
2016-09-09 18:42 ` Omar Sandoval [this message]
2016-09-09 18:42 ` [PATCH v3 3/5] sbitmap: push per-cpu last_tag into sbitmap_queue Omar Sandoval
2016-09-09 18:42 ` [PATCH v3 4/5] sbitmap: push alloc policy " Omar Sandoval
2016-09-09 18:42 ` [PATCH v3 5/5] sbitmap: randomize initial last_cache values Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab0ffdba530d6dffb86c47745c2976a9be53dd5d.1473446095.git.osandov@fb.com \
--to=osandov@osandov.com \
--cc=ast@fb.com \
--cc=axboe@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).