From: Clemens Gruber <clemens.gruber@pqgruber.com>
To: linux-hwmon@vger.kernel.org
Cc: Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Clemens Gruber <clemens.gruber@pqgruber.com>
Subject: [PATCH v2 3/3] hwmon: (mcp3021) replace S_IRUGO with 0444
Date: Fri, 28 Oct 2016 00:33:45 +0200 [thread overview]
Message-ID: <20161027223345.16733-3-clemens.gruber@pqgruber.com> (raw)
In-Reply-To: <20161027223345.16733-1-clemens.gruber@pqgruber.com>
Replace S_IRUGO with the better readable 0444.
This fixes a checkpatch warning.
Signed-off-by: Clemens Gruber <clemens.gruber@pqgruber.com>
---
drivers/hwmon/mcp3021.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/mcp3021.c b/drivers/hwmon/mcp3021.c
index a8cf97f..97c832d 100644
--- a/drivers/hwmon/mcp3021.c
+++ b/drivers/hwmon/mcp3021.c
@@ -120,7 +120,7 @@ static ssize_t show_in_input(struct device *dev, struct device_attribute *attr,
return sprintf(buf, "%d\n", in_input);
}
-static DEVICE_ATTR(in0_input, S_IRUGO, show_in_input, NULL);
+static DEVICE_ATTR(in0_input, 0444, show_in_input, NULL);
#ifdef CONFIG_OF
static int mcp3021_probe_dt(struct i2c_client *client,
--
2.10.1
next prev parent reply other threads:[~2016-10-27 22:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 22:33 [PATCH v2 1/3] hwmon: (mcp3021) rework for DT support Clemens Gruber
2016-10-27 22:33 ` [PATCH v2 2/3] hwmon: (mcp3021) add devicetree bindings documentation Clemens Gruber
2016-10-31 6:04 ` Rob Herring
2016-11-19 16:28 ` [v2,2/3] " Guenter Roeck
2016-10-27 22:33 ` Clemens Gruber [this message]
2016-11-09 11:53 ` [PATCH v2 1/3] hwmon: (mcp3021) rework for DT support Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027223345.16733-3-clemens.gruber@pqgruber.com \
--to=clemens.gruber@pqgruber.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).