From: Sascha Hauer <s.hauer@pengutronix.de>
To: linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
<linux-arm-kernel@lists.infradead.org>,
kernel@pengutronix.de, Sascha Hauer <s.hauer@pengutronix.de>
Subject: [PATCH 4/4] serial: imx: Add LED trigger support
Date: Wed, 23 Nov 2016 11:01:06 +0100 [thread overview]
Message-ID: <20161123100106.15969-5-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20161123100106.15969-1-s.hauer@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/tty/serial/imx.c | 24 ++++++++++++++++++++++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index a70356d..5eaf576 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -444,6 +444,8 @@ static inline void imx_transmit_buffer(struct imx_port *sport)
return;
}
+ uart_led_trigger_tx(&sport->port);
+
if (sport->dma_is_enabled) {
/*
* We've just sent a X-char Ensure the TX DMA is enabled
@@ -569,6 +571,7 @@ static void imx_dma_tx(struct imx_port *sport)
/* fire it */
sport->dma_is_txing = 1;
dmaengine_submit(desc);
+ uart_led_trigger_tx(&sport->port);
dma_async_issue_pending(chan);
return;
}
@@ -655,6 +658,8 @@ static irqreturn_t imx_rxint(int irq, void *dev_id)
struct tty_port *port = &sport->port.state->port;
unsigned long flags, temp;
+ uart_led_trigger_rx(&sport->port);
+
spin_lock_irqsave(&sport->port.lock, flags);
while (readl(sport->port.membase + USR2) & USR2_RDR) {
@@ -729,6 +734,8 @@ static void imx_dma_rxint(struct imx_port *sport)
unsigned long temp;
unsigned long flags;
+ uart_led_trigger_rx(&sport->port);
+
spin_lock_irqsave(&sport->port.lock, flags);
temp = readl(sport->port.membase + USR2);
@@ -2184,14 +2191,27 @@ static int serial_imx_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, sport);
- return uart_add_one_port(&imx_reg, &sport->port);
+ ret = uart_add_one_port(&imx_reg, &sport->port);
+ if (ret)
+ return ret;
+
+ uart_add_led_triggers(&imx_reg, &sport->port);
+
+ return 0;
}
static int serial_imx_remove(struct platform_device *pdev)
{
struct imx_port *sport = platform_get_drvdata(pdev);
+ int ret;
- return uart_remove_one_port(&imx_reg, &sport->port);
+ ret = uart_remove_one_port(&imx_reg, &sport->port);
+ if (ret)
+ return ret;
+
+ uart_remove_led_triggers(&sport->port);
+
+ return 0;
}
static void serial_imx_restore_context(struct imx_port *sport)
--
2.10.2
next prev parent reply other threads:[~2016-11-23 10:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 10:01 serial: Add LED trigger support Sascha Hauer
2016-11-23 10:01 ` [PATCH 1/4] serial: core: " Sascha Hauer
2016-11-23 10:08 ` Greg Kroah-Hartman
2016-11-23 10:18 ` Sascha Hauer
2016-11-24 8:26 ` Sascha Hauer
2016-11-24 9:59 ` Greg Kroah-Hartman
2016-11-23 17:13 ` Mathieu Poirier
2016-11-24 6:41 ` Sascha Hauer
2016-11-24 15:45 ` Mathieu Poirier
2016-11-25 12:49 ` Sascha Hauer
2016-11-23 18:57 ` Florian Fainelli
2016-11-24 8:17 ` Sascha Hauer
2016-11-28 4:39 ` Florian Fainelli
2016-12-06 16:54 ` One Thousand Gnomes
2016-12-25 21:20 ` Pavel Machek
2016-11-23 20:07 ` kbuild test robot
2016-12-25 21:20 ` Pavel Machek
2016-11-23 10:01 ` [PATCH 2/4] serial: 8250: " Sascha Hauer
2016-11-23 19:40 ` kbuild test robot
2016-11-23 10:01 ` [PATCH 3/4] serial: cpm_uart: " Sascha Hauer
2016-11-23 10:01 ` Sascha Hauer [this message]
2016-11-24 4:46 ` [PATCH 4/4] serial: imx: " kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123100106.15969-5-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).