From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, santosh.shilimkar@oracle.com
Subject: [net-next][PATCH v2 10/18] RDS: IB: track and log active side endpoint in connection
Date: Tue, 6 Dec 2016 20:01:48 -0800 [thread overview]
Message-ID: <1481083316-11648-11-git-send-email-santosh.shilimkar@oracle.com> (raw)
In-Reply-To: <1481083316-11648-1-git-send-email-santosh.shilimkar@oracle.com>
Useful to know the active and passive end points in a
RDS IB connection.
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
---
net/rds/ib.h | 3 +++
net/rds/ib_cm.c | 11 +++++++----
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/net/rds/ib.h b/net/rds/ib.h
index f14c26d..97e7696 100644
--- a/net/rds/ib.h
+++ b/net/rds/ib.h
@@ -181,6 +181,9 @@ struct rds_ib_connection {
/* Batched completions */
unsigned int i_unsignaled_wrs;
+
+ /* Endpoint role in connection */
+ int i_active_side;
};
/* This assumes that atomic_t is at least 32 bits */
diff --git a/net/rds/ib_cm.c b/net/rds/ib_cm.c
index 3002acf..4d1bf04 100644
--- a/net/rds/ib_cm.c
+++ b/net/rds/ib_cm.c
@@ -120,16 +120,17 @@ void rds_ib_cm_connect_complete(struct rds_connection *conn, struct rdma_cm_even
rds_conn_destroy(conn);
return;
} else {
- pr_notice("RDS/IB: connected <%pI4,%pI4> version %u.%u%s\n",
+ pr_notice("RDS/IB: %s conn connected <%pI4,%pI4> version %u.%u%s\n",
+ ic->i_active_side ? "Active" : "Passive",
&conn->c_laddr, &conn->c_faddr,
RDS_PROTOCOL_MAJOR(conn->c_version),
RDS_PROTOCOL_MINOR(conn->c_version),
ic->i_flowctl ? ", flow control" : "");
}
- /*
- * Init rings and fill recv. this needs to wait until protocol negotiation
- * is complete, since ring layout is different from 3.0 to 3.1.
+ /* Init rings and fill recv. this needs to wait until protocol
+ * negotiation is complete, since ring layout is different
+ * from 3.1 to 4.1.
*/
rds_ib_send_init_ring(ic);
rds_ib_recv_init_ring(ic);
@@ -685,6 +686,7 @@ int rds_ib_cm_initiate_connect(struct rdma_cm_id *cm_id)
if (ic->i_cm_id == cm_id)
ret = 0;
}
+ ic->i_active_side = true;
return ret;
}
@@ -859,6 +861,7 @@ void rds_ib_conn_path_shutdown(struct rds_conn_path *cp)
ic->i_sends = NULL;
vfree(ic->i_recvs);
ic->i_recvs = NULL;
+ ic->i_active_side = false;
}
int rds_ib_conn_alloc(struct rds_connection *conn, gfp_t gfp)
--
1.9.1
next prev parent reply other threads:[~2016-12-07 4:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 4:01 [net-next][PATCH v2 00/18] net: RDS updates Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 01/18] RDS: log the address on bind failure Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 02/18] RDS: mark few internal functions static to make sparse build happy Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 03/18] RDS: IB: include faddr in connection log Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 04/18] RDS: IB: make the transport retry count smallest Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 05/18] RDS: RDMA: fix the ib_map_mr_sg_zbva() argument Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 06/18] RDS: RDMA: start rdma listening after init Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 07/18] RDS: RDMA: return appropriate error on rdma map failures Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 08/18] RDS: IB: split the mr registration and invalidation path Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 09/18] RDS: RDMA: silence the use_once mr log flood Santosh Shilimkar
2016-12-07 4:01 ` Santosh Shilimkar [this message]
2016-12-07 15:53 ` [net-next][PATCH v2 10/18] RDS: IB: track and log active side endpoint in connection David Miller
2016-12-07 16:29 ` Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 11/18] RDS: IB: add few useful cache stasts Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 12/18] RDS: IB: Add vector spreading for cqs Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 13/18] RDS: RDMA: Fix the composite message user notification Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 14/18] RDS: IB: fix panic due to handlers running post teardown Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 15/18] RDS: add stat for socket recv memory usage Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 16/18] RDS: make message size limit compliant with spec Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 17/18] RDS: add receive message trace used by application Santosh Shilimkar
2016-12-07 4:01 ` [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info Santosh Shilimkar
2016-12-07 15:55 ` David Miller
2016-12-07 16:44 ` Santosh Shilimkar
2016-12-07 17:05 ` David Miller
2016-12-07 17:20 ` Santosh Shilimkar
2016-12-07 17:36 ` David Miller
2016-12-07 20:42 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481083316-11648-11-git-send-email-santosh.shilimkar@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).