linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Joe Perches <joe@perches.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Petr Mladek <pmladek@suse.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH] printk: Remove no longer used second struct cont
Date: Thu, 15 Dec 2016 13:53:58 +0100	[thread overview]
Message-ID: <1481806438-30185-1-git-send-email-geert@linux-m68k.org> (raw)

If CONFIG_PRINTK=n:

    kernel/printk/printk.c:1893: warning: ‘cont’ defined but not used

Note that there are actually two different struct cont definitions and
objects: the first one is used if CONFIG_PRINTK=y, the second one became
unused by removing console_cont_flush().

Fixes: 5c2992ee7fd8a29d ("printk: remove console flushing special cases for partial buffered lines")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 kernel/printk/printk.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index b3c454b733da8163..bc2e220ed2b0bce5 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -1885,12 +1885,6 @@ asmlinkage __visible int printk(const char *fmt, ...)
 static u64 log_first_seq;
 static u32 log_first_idx;
 static u64 log_next_seq;
-static struct cont {
-	size_t len;
-	size_t cons;
-	u8 level;
-	bool flushed:1;
-} cont;
 static char *log_text(const struct printk_log *msg) { return NULL; }
 static char *log_dict(const struct printk_log *msg) { return NULL; }
 static struct printk_log *log_from_idx(u32 idx) { return NULL; }
-- 
1.9.1

             reply	other threads:[~2016-12-15 13:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-15 12:53 Geert Uytterhoeven [this message]
2016-12-15 16:23 ` [PATCH] printk: Remove no longer used second struct cont Petr Mladek
2016-12-16  1:37   ` Sergey Senozhatsky
2016-12-16  1:39     ` Joe Perches
2016-12-16  1:50       ` Sergey Senozhatsky
2016-12-16  1:50     ` Linus Torvalds
2016-12-16  1:57       ` Joe Perches
2016-12-16  2:10         ` Linus Torvalds
2016-12-16  2:30           ` Joe Perches
2016-12-16  5:00             ` Junio C Hamano
2016-12-16  6:04               ` Joe Perches
2016-12-16  2:00       ` Sergey Senozhatsky
2016-12-18 19:29       ` Scott Matheina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481806438-30185-1-git-send-email-geert@linux-m68k.org \
    --to=geert@linux-m68k.org \
    --cc=akpm@linux-foundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).