linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: linux-kernel@vger.kernel.org, santosh.shilimkar@oracle.com
Subject: [net-next][PATCH v3 02/17] RDS: mark few internal functions static to make sparse build happy
Date: Mon,  2 Jan 2017 14:45:37 -0800	[thread overview]
Message-ID: <1483397152-8307-3-git-send-email-santosh.shilimkar@oracle.com> (raw)
In-Reply-To: <1483397152-8307-1-git-send-email-santosh.shilimkar@oracle.com>

Fixes below warnings:
warning: symbol 'rds_send_probe' was not declared. Should it be static?
warning: symbol 'rds_send_ping' was not declared. Should it be static?
warning: symbol 'rds_tcp_accept_one_path' was not declared. Should it be static?
warning: symbol 'rds_walk_conn_path_info' was not declared. Should it be static?

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
---
 net/rds/connection.c | 10 +++++-----
 net/rds/send.c       |  4 ++--
 net/rds/tcp_listen.c |  1 +
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/net/rds/connection.c b/net/rds/connection.c
index fe9d31c..0e04dcc 100644
--- a/net/rds/connection.c
+++ b/net/rds/connection.c
@@ -545,11 +545,11 @@ void rds_for_each_conn_info(struct socket *sock, unsigned int len,
 }
 EXPORT_SYMBOL_GPL(rds_for_each_conn_info);
 
-void rds_walk_conn_path_info(struct socket *sock, unsigned int len,
-			     struct rds_info_iterator *iter,
-			     struct rds_info_lengths *lens,
-			     int (*visitor)(struct rds_conn_path *, void *),
-			     size_t item_len)
+static void rds_walk_conn_path_info(struct socket *sock, unsigned int len,
+				    struct rds_info_iterator *iter,
+				    struct rds_info_lengths *lens,
+				    int (*visitor)(struct rds_conn_path *, void *),
+				    size_t item_len)
 {
 	u64  buffer[(item_len + 7) / 8];
 	struct hlist_head *head;
diff --git a/net/rds/send.c b/net/rds/send.c
index 77c8c6e..bb13c56 100644
--- a/net/rds/send.c
+++ b/net/rds/send.c
@@ -1169,7 +1169,7 @@ int rds_sendmsg(struct socket *sock, struct msghdr *msg, size_t payload_len)
  * or
  *   RDS_FLAG_HB_PONG|RDS_FLAG_ACK_REQUIRED
  */
-int
+static int
 rds_send_probe(struct rds_conn_path *cp, __be16 sport,
 	       __be16 dport, u8 h_flags)
 {
@@ -1238,7 +1238,7 @@ int rds_sendmsg(struct socket *sock, struct msghdr *msg, size_t payload_len)
 	return rds_send_probe(cp, 0, dport, 0);
 }
 
-void
+static void
 rds_send_ping(struct rds_connection *conn)
 {
 	unsigned long flags;
diff --git a/net/rds/tcp_listen.c b/net/rds/tcp_listen.c
index f74bab3..67d0929 100644
--- a/net/rds/tcp_listen.c
+++ b/net/rds/tcp_listen.c
@@ -79,6 +79,7 @@ int rds_tcp_keepalive(struct socket *sock)
  * smaller ip address, we recycle conns in RDS_CONN_ERROR on the passive side
  * by moving them to CONNECTING in this function.
  */
+static
 struct rds_tcp_connection *rds_tcp_accept_one_path(struct rds_connection *conn)
 {
 	int i;
-- 
1.9.1

  parent reply	other threads:[~2017-01-02 22:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 22:45 [net-next][PATCH v3 00/17] net: RDS updates Santosh Shilimkar
2017-01-02 22:45 ` [net-next][PATCH v3 01/17] RDS: log the address on bind failure Santosh Shilimkar
2017-01-02 22:45 ` Santosh Shilimkar [this message]
2017-01-02 22:45 ` [net-next][PATCH v3 03/17] RDS: IB: include faddr in connection log Santosh Shilimkar
2017-01-02 22:45 ` [net-next][PATCH v3 04/17] RDS: IB: make the transport retry count smallest Santosh Shilimkar
2017-01-02 22:45 ` [net-next][PATCH v3 05/17] RDS: RDMA: fix the ib_map_mr_sg_zbva() argument Santosh Shilimkar
2017-01-02 22:45 ` [net-next][PATCH v3 06/17] RDS: RDMA: start rdma listening after init Santosh Shilimkar
2017-01-02 22:45 ` [net-next][PATCH v3 07/17] RDS: RDMA: return appropriate error on rdma map failures Santosh Shilimkar
2017-01-02 22:45 ` [net-next][PATCH v3 08/17] RDS: IB: split the mr registration and invalidation path Santosh Shilimkar
2017-01-02 22:45 ` [net-next][PATCH v3 09/17] RDS: RDMA: silence the use_once mr log flood Santosh Shilimkar
2017-01-02 22:45 ` [net-next][PATCH v3 10/17] RDS: IB: track and log active side endpoint in connection Santosh Shilimkar
2017-01-02 22:45 ` [net-next][PATCH v3 11/17] RDS: IB: add few useful cache stasts Santosh Shilimkar
2017-01-02 22:45 ` [net-next][PATCH v3 12/17] RDS: IB: Add vector spreading for cqs Santosh Shilimkar
2017-01-02 22:45 ` [net-next][PATCH v3 13/17] RDS: RDMA: Fix the composite message user notification Santosh Shilimkar
2017-01-02 22:45 ` [net-next][PATCH v3 14/17] RDS: IB: fix panic due to handlers running post teardown Santosh Shilimkar
2017-01-02 22:45 ` [net-next][PATCH v3 15/17] RDS: add stat for socket recv memory usage Santosh Shilimkar
2017-01-02 22:45 ` [net-next][PATCH v3 16/17] RDS: make message size limit compliant with spec Santosh Shilimkar
2017-01-02 22:45 ` [net-next][PATCH v3 17/17] RDS: add receive message trace used by application Santosh Shilimkar
2017-01-03 14:46 ` [net-next][PATCH v3 00/17] net: RDS updates David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483397152-8307-3-git-send-email-santosh.shilimkar@oracle.com \
    --to=santosh.shilimkar@oracle.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).