From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Tejun Heo <tj@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-ide@vger.kernel.org, linux-m68k@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH 4/6] ata: AHCI and other non-SFF native drivers should depend on HAS_DMA
Date: Tue, 3 Jan 2017 19:09:47 +0100 [thread overview]
Message-ID: <1483466989-9091-5-git-send-email-geert@linux-m68k.org> (raw)
In-Reply-To: <1483466989-9091-1-git-send-email-geert@linux-m68k.org>
If NO_DMA=y:
ERROR: "bad_dma_ops" [drivers/ata/libahci_platform.ko] undefined!
ERROR: "dmam_alloc_coherent" [drivers/ata/libahci.ko] undefined!
Add a block dependency on HAS_DMA to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/ata/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index a973aa8aa5513eea..78c00202102913a0 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -80,6 +80,8 @@ config SATA_PMP
This option adds support for SATA Port Multipliers
(the SATA version of an ethernet hub, or SAS expander).
+if HAS_DMA
+
comment "Controllers with non-SFF native interface"
config SATA_AHCI
@@ -232,6 +234,8 @@ config SATA_SIL24
If unsure, say N.
+endif # HAS_DMA
+
config ATA_SFF
bool "ATA SFF support (for legacy IDE and PATA)"
default y
--
1.9.1
next prev parent reply other threads:[~2017-01-03 18:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 18:09 [PATCH 0/6] ata: Missing HAS_DMA dependencies Geert Uytterhoeven
2017-01-03 18:09 ` [PATCH 1/6] ata: SATA_MV should depend on HAS_DMA Geert Uytterhoeven
2017-01-03 18:09 ` [PATCH 2/6] ata: SATA_HIGHBANK " Geert Uytterhoeven
2017-01-03 18:09 ` [PATCH 3/6] ata: ATA_BMDMA " Geert Uytterhoeven
2017-01-03 18:09 ` Geert Uytterhoeven [this message]
2017-01-03 18:09 ` [PATCH 5/6] libata: Make ata_sg_clean() static again Geert Uytterhoeven
2017-01-03 18:09 ` [PATCH 6/6] libata: Protect DMA core code by #ifdef CONFIG_HAS_DMA Geert Uytterhoeven
2017-01-06 16:37 ` [PATCH 0/6] ata: Missing HAS_DMA dependencies Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483466989-9091-5-git-send-email-geert@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=b.zolnierkie@samsung.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).