From: Tim Schmielau <tim@physik3.uni-rostock.de>
To: lkml <linux-kernel@vger.kernel.org>
Subject: [patch 3/3] break out task_struct from sched.h
Date: Fri, 19 Jul 2002 19:02:20 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.33.0207191856080.23556-100000@gans.physik3.uni-rostock.de> (raw)
In-Reply-To: <Pine.LNX.4.33.0207191825120.23556-100000@gans.physik3.uni-rostock.de>
Move task_struct from <linux/sched.h> to its own header file
<linux/task_struct.h>, and include it in sched.h.
Remove now unused #includes in sched.h, which get included
through task_struct.h anyways.
With this change files doing "current->foo" may include only
task_struct.h instead of the whole sched.h.
This also fixes references of current->foo that my scripts werent able to
detect.
Please report success with the patches as well as problems to
tim@physik3.uni-rostock.de
Tim
--- linux-2.5.26-sr1/include/linux/sched.h Wed Jul 17 01:49:25 2002
+++ linux-2.5.26-sr2/include/linux/sched.h Fri Jul 19 17:36:58 2002
@@ -9,11 +9,11 @@
#include <linux/capability.h>
#include <linux/threads.h>
#include <linux/kernel.h>
-#include <linux/types.h>
#include <linux/timex.h>
#include <linux/jiffies.h>
#include <linux/rbtree.h>
#include <linux/thread_info.h>
+#include <linux/task_struct.h>
#include <asm/system.h>
#include <asm/semaphore.h>
@@ -22,7 +23,6 @@
#include <asm/mmu.h>
#include <linux/smp.h>
-#include <linux/sem.h>
#include <linux/signal.h>
#include <linux/securebits.h>
#include <linux/fs_struct.h>
@@ -82,10 +82,6 @@
#include <linux/time.h>
#include <linux/param.h>
-#include <linux/resource.h>
-#include <linux/timer.h>
-
-#include <asm/processor.h>
#define TASK_RUNNING 0
#define TASK_INTERRUPTIBLE 1
@@ -243,127 +239,6 @@
extern struct user_struct root_user;
#define INIT_USER (&root_user)
-
-typedef struct prio_array prio_array_t;
-
-struct task_struct {
- volatile long state; /* -1 unrunnable, 0 runnable, >0 stopped */
- struct thread_info *thread_info;
- atomic_t usage;
- unsigned long flags; /* per process flags, defined below */
- unsigned long ptrace;
-
- int lock_depth; /* Lock depth */
-
- int prio, static_prio;
- list_t run_list;
- prio_array_t *array;
-
- unsigned long sleep_avg;
- unsigned long sleep_timestamp;
-
- unsigned long policy;
- unsigned long cpus_allowed;
- unsigned int time_slice;
-
- struct list_head tasks;
-
- struct mm_struct *mm, *active_mm;
- struct list_head local_pages;
-
- unsigned int allocation_order, nr_local_pages;
-
-/* task state */
- struct linux_binfmt *binfmt;
- int exit_code, exit_signal;
- int pdeath_signal; /* The signal sent when the parent dies */
- /* ??? */
- unsigned long personality;
- int did_exec:1;
- pid_t pid;
- pid_t pgrp;
- pid_t tty_old_pgrp;
- pid_t session;
- pid_t tgid;
- /* boolean value for session group leader */
- int leader;
- /*
- * pointers to (original) parent process, youngest child, younger sibling,
- * older sibling, respectively. (p->father can be replaced with
- * p->parent->pid)
- */
- struct task_struct *real_parent; /* real parent process (when being debugged) */
- struct task_struct *parent; /* parent process */
- struct list_head children; /* list of my children */
- struct list_head sibling; /* linkage in my parent's children list */
- struct list_head thread_group;
-
- /* PID hash table linkage. */
- struct task_struct *pidhash_next;
- struct task_struct **pidhash_pprev;
-
- wait_queue_head_t wait_chldexit; /* for wait4() */
- struct completion *vfork_done; /* for vfork() */
-
- unsigned long rt_priority;
- unsigned long it_real_value, it_prof_value, it_virt_value;
- unsigned long it_real_incr, it_prof_incr, it_virt_incr;
- struct timer_list real_timer;
- unsigned long utime, stime, cutime, cstime;
- unsigned long start_time;
- long per_cpu_utime[NR_CPUS], per_cpu_stime[NR_CPUS];
-/* mm fault and swap info: this can arguably be seen as either mm-specific or thread-specific */
- unsigned long min_flt, maj_flt, nswap, cmin_flt, cmaj_flt, cnswap;
- int swappable:1;
-/* process credentials */
- uid_t uid,euid,suid,fsuid;
- gid_t gid,egid,sgid,fsgid;
- int ngroups;
- gid_t groups[NGROUPS];
- kernel_cap_t cap_effective, cap_inheritable, cap_permitted;
- int keep_capabilities:1;
- struct user_struct *user;
-/* limits */
- struct rlimit rlim[RLIM_NLIMITS];
- unsigned short used_math;
- char comm[16];
-/* file system info */
- int link_count, total_link_count;
- struct tty_struct *tty; /* NULL if no tty */
- unsigned int locks; /* How many file locks are being held */
-/* ipc stuff */
- struct sysv_sem sysvsem;
-/* CPU-specific state of this task */
- struct thread_struct thread;
-/* filesystem information */
- struct fs_struct *fs;
-/* open file information */
- struct files_struct *files;
-/* namespace */
- struct namespace *namespace;
-/* signal handlers */
- spinlock_t sigmask_lock; /* Protects signal and blocked */
- struct signal_struct *sig;
-
- sigset_t blocked;
- struct sigpending pending;
-
- unsigned long sas_ss_sp;
- size_t sas_ss_size;
- int (*notifier)(void *priv);
- void *notifier_data;
- sigset_t *notifier_mask;
-
-/* Thread group tracking */
- u32 parent_exec_id;
- u32 self_exec_id;
-/* Protection of (de-)allocation: mm, files, fs, tty */
- spinlock_t alloc_lock;
-
-/* journalling filesystem info */
- void *journal_info;
- struct dentry *proc_dentry;
-};
extern void __put_task_struct(struct task_struct *tsk);
#define get_task_struct(tsk) do { atomic_inc(&(tsk)->usage); } while(0)
--- linux-2.5.26-sr1/include/linux/task_struct.h Thu Jan 1 01:00:00 1970
+++ linux-2.5.26-sr2/include/linux/task_struct.h Fri Jul 19 17:36:44 2002
@@ -0,0 +1,144 @@
+#ifndef _LINUX_TASK_STRUCT_H
+#define _LINUX_TASK_STRUCT_H
+
+#include <asm/atomic.h> /* sem.h needs this first */
+#include <linux/capability.h>
+#include <linux/types.h>
+#include <linux/times.h>
+#include <linux/spinlock.h>
+#include <linux/sem.h>
+#include <linux/signal.h>
+#include <linux/resource.h>
+#include <linux/timer.h>
+#include <asm/processor.h>
+
+#ifdef __KERNEL__
+
+#include <linux/list.h>
+#include <linux/wait.h>
+
+
+typedef struct prio_array prio_array_t;
+
+struct task_struct {
+ volatile long state; /* -1 unrunnable, 0 runnable, >0 stopped */
+ struct thread_info *thread_info;
+ atomic_t usage;
+ unsigned long flags; /* per process flags, defined below */
+ unsigned long ptrace;
+
+ int lock_depth; /* Lock depth */
+
+ int prio, static_prio;
+ list_t run_list;
+ prio_array_t *array;
+
+ unsigned long sleep_avg;
+ unsigned long sleep_timestamp;
+
+ unsigned long policy;
+ unsigned long cpus_allowed;
+ unsigned int time_slice;
+
+ struct list_head tasks;
+
+ struct mm_struct *mm, *active_mm;
+ struct list_head local_pages;
+
+ unsigned int allocation_order, nr_local_pages;
+
+/* task state */
+ struct linux_binfmt *binfmt;
+ int exit_code, exit_signal;
+ int pdeath_signal; /* The signal sent when the parent dies */
+ /* ??? */
+ unsigned long personality;
+ int did_exec:1;
+ pid_t pid;
+ pid_t pgrp;
+ pid_t tty_old_pgrp;
+ pid_t session;
+ pid_t tgid;
+ /* boolean value for session group leader */
+ int leader;
+ /*
+ * pointers to (original) parent process, youngest child, younger sibling,
+ * older sibling, respectively. (p->father can be replaced with
+ * p->parent->pid)
+ */
+ struct task_struct *real_parent; /* real parent process (when being debugged) */
+ struct task_struct *parent; /* parent process */
+ struct list_head children; /* list of my children */
+ struct list_head sibling; /* linkage in my parent's children list */
+ struct list_head thread_group;
+
+ /* PID hash table linkage. */
+ struct task_struct *pidhash_next;
+ struct task_struct **pidhash_pprev;
+
+ wait_queue_head_t wait_chldexit; /* for wait4() */
+ struct completion *vfork_done; /* for vfork() */
+
+ unsigned long rt_priority;
+ unsigned long it_real_value, it_prof_value, it_virt_value;
+ unsigned long it_real_incr, it_prof_incr, it_virt_incr;
+ struct timer_list real_timer;
+ unsigned long utime, stime, cutime, cstime;
+ unsigned long start_time;
+ long per_cpu_utime[NR_CPUS], per_cpu_stime[NR_CPUS];
+/* mm fault and swap info: this can arguably be seen as either mm-specific or thread-specific */
+ unsigned long min_flt, maj_flt, nswap, cmin_flt, cmaj_flt, cnswap;
+ int swappable:1;
+/* process credentials */
+ uid_t uid,euid,suid,fsuid;
+ gid_t gid,egid,sgid,fsgid;
+ int ngroups;
+ gid_t groups[NGROUPS];
+ kernel_cap_t cap_effective, cap_inheritable, cap_permitted;
+ int keep_capabilities:1;
+ struct user_struct *user;
+/* limits */
+ struct rlimit rlim[RLIM_NLIMITS];
+ unsigned short used_math;
+ char comm[16];
+/* file system info */
+ int link_count, total_link_count;
+ struct tty_struct *tty; /* NULL if no tty */
+ unsigned int locks; /* How many file locks are being held */
+/* ipc stuff */
+ struct sysv_sem sysvsem;
+/* CPU-specific state of this task */
+ struct thread_struct thread;
+/* filesystem information */
+ struct fs_struct *fs;
+/* open file information */
+ struct files_struct *files;
+/* namespace */
+ struct namespace *namespace;
+/* signal handlers */
+ spinlock_t sigmask_lock; /* Protects signal and blocked */
+ struct signal_struct *sig;
+
+ sigset_t blocked;
+ struct sigpending pending;
+
+ unsigned long sas_ss_sp;
+ size_t sas_ss_size;
+ int (*notifier)(void *priv);
+ void *notifier_data;
+ sigset_t *notifier_mask;
+
+/* Thread group tracking */
+ u32 parent_exec_id;
+ u32 self_exec_id;
+/* Protection of (de-)allocation: mm, files, fs, tty */
+ spinlock_t alloc_lock;
+
+/* journalling filesystem info */
+ void *journal_info;
+ struct dentry *proc_dentry;
+};
+
+#endif /* __KERNEL__ */
+
+#endif /* _LINUX_TASK_STRUCT_H */
--- linux-2.5.26-sr1/include/asm-alpha/current.h Wed Jul 17 01:49:38 2002
+++ linux-2.5.26-sr2/include/asm-alpha/current.h Fri Jul 19 17:34:37 2002
@@ -1,6 +1,7 @@
#ifndef _ALPHA_CURRENT_H
#define _ALPHA_CURRENT_H
+#include <linux/task_struct.h>
#include <asm/thread_info.h>
#define get_current() (current_thread_info()->task + 0)
--- linux-2.5.26-sr1/include/asm-arm/current.h Wed Jul 17 01:49:35 2002
+++ linux-2.5.26-sr2/include/asm-arm/current.h Fri Jul 19 17:34:37 2002
@@ -1,6 +1,7 @@
#ifndef _ASMARM_CURRENT_H
#define _ASMARM_CURRENT_H
+#include <linux/task_struct.h>
#include <asm/thread_info.h>
static inline struct task_struct *get_current(void) __attribute__ (( __const__ ));
--- linux-2.5.26-sr1/include/asm-cris/current.h Wed Jul 17 01:49:33 2002
+++ linux-2.5.26-sr2/include/asm-cris/current.h Fri Jul 19 17:34:37 2002
@@ -1,7 +1,7 @@
#ifndef _CRIS_CURRENT_H
#define _CRIS_CURRENT_H
-struct task_struct;
+#include <linux/task_struct.h>
static inline struct task_struct * get_current(void)
{
--- linux-2.5.26-sr1/include/asm-i386/current.h Wed Jul 17 01:49:31 2002
+++ linux-2.5.26-sr2/include/asm-i386/current.h Fri Jul 19 17:34:37 2002
@@ -1,9 +1,8 @@
#ifndef _I386_CURRENT_H
#define _I386_CURRENT_H
+#include <linux/task_struct.h>
#include <asm/thread_info.h>
-
-struct task_struct;
static inline struct task_struct * get_current(void)
{
--- linux-2.5.26-sr1/include/asm-ia64/current.h Wed Jul 17 01:49:29 2002
+++ linux-2.5.26-sr2/include/asm-ia64/current.h Fri Jul 19 17:34:37 2002
@@ -1,6 +1,8 @@
#ifndef _ASM_IA64_CURRENT_H
#define _ASM_IA64_CURRENT_H
+#include <linux/task_struct.h>
+
/*
* Copyright (C) 1998-2000 Hewlett-Packard Co
* David Mosberger-Tang <davidm@hpl.hp.com>
--- linux-2.5.26-sr1/include/asm-m68k/current.h Wed Jul 17 01:49:25 2002
+++ linux-2.5.26-sr2/include/asm-m68k/current.h Fri Jul 19 17:34:37 2002
@@ -1,6 +1,8 @@
#ifndef _M68K_CURRENT_H
#define _M68K_CURRENT_H
+#include <linux/task_struct.h>
+
register struct task_struct *current __asm__("%a2");
#endif /* !(_M68K_CURRENT_H) */
--- linux-2.5.26-sr1/include/asm-mips/current.h Wed Jul 17 01:49:26 2002
+++ linux-2.5.26-sr2/include/asm-mips/current.h Fri Jul 19 17:34:37 2002
@@ -11,6 +11,8 @@
#ifdef _LANGUAGE_C
+#include <linux/task_struct.h>
+
/* MIPS rules... */
register struct task_struct *current asm("$28");
--- linux-2.5.26-sr1/include/asm-mips64/current.h Wed Jul 17 01:49:26 2002
+++ linux-2.5.26-sr2/include/asm-mips64/current.h Fri Jul 19 17:34:37 2002
@@ -10,6 +10,8 @@
#ifdef _LANGUAGE_C
+#include <linux/task_struct.h>
+
/* MIPS rules... */
register struct task_struct *current asm("$28");
--- linux-2.5.26-sr1/include/asm-parisc/current.h Wed Jul 17 01:49:34 2002
+++ linux-2.5.26-sr2/include/asm-parisc/current.h Fri Jul 19 17:34:37 2002
@@ -1,9 +1,8 @@
#ifndef _PARISC_CURRENT_H
#define _PARISC_CURRENT_H
+#include <linux/task_struct.h>
#include <asm/processor.h>
-
-struct task_struct;
static inline struct task_struct * get_current(void)
{
--- linux-2.5.26-sr1/include/asm-ppc/current.h Wed Jul 17 01:49:26 2002
+++ linux-2.5.26-sr2/include/asm-ppc/current.h Fri Jul 19 17:34:37 2002
@@ -5,6 +5,8 @@
#ifndef _PPC_CURRENT_H
#define _PPC_CURRENT_H
+#include <linux/task_struct.h>
+
/*
* We keep `current' in r2 for speed.
*/
--- linux-2.5.26-sr1/include/asm-ppc64/current.h Wed Jul 17 01:49:26 2002
+++ linux-2.5.26-sr2/include/asm-ppc64/current.h Fri Jul 19 17:34:37 2002
@@ -1,6 +1,8 @@
#ifndef _PPC64_CURRENT_H
#define _PPC64_CURRENT_H
+#include <linux/task_struct.h>
+
/*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
--- linux-2.5.26-sr1/include/asm-s390/current.h Wed Jul 17 01:49:32 2002
+++ linux-2.5.26-sr2/include/asm-s390/current.h Fri Jul 19 17:34:37 2002
@@ -13,9 +13,8 @@
#ifdef __KERNEL__
+#include <linux/task_struct.h>
#include <asm/thread_info.h>
-
-struct task_struct;
static inline struct task_struct * get_current(void)
{
--- linux-2.5.26-sr1/include/asm-s390x/current.h Wed Jul 17 01:49:38 2002
+++ linux-2.5.26-sr2/include/asm-s390x/current.h Fri Jul 19 17:34:37 2002
@@ -13,9 +13,8 @@
#ifdef __KERNEL__
+#include <linux/task_struct.h>
#include <asm/thread_info.h>
-
-struct task_struct;
static inline struct task_struct * get_current(void)
{
--- linux-2.5.26-sr1/include/asm-sh/current.h Wed Jul 17 01:49:32 2002
+++ linux-2.5.26-sr2/include/asm-sh/current.h Fri Jul 19 17:34:37 2002
@@ -6,7 +6,7 @@
*
*/
-struct task_struct;
+#include <linux/task_struct.h>
static __inline__ struct task_struct * get_current(void)
{
--- linux-2.5.26-sr1/include/asm-sparc/current.h Wed Jul 17 01:49:25 2002
+++ linux-2.5.26-sr2/include/asm-sparc/current.h Fri Jul 19 17:34:37 2002
@@ -1,6 +1,8 @@
#ifndef _SPARC_CURRENT_H
#define _SPARC_CURRENT_H
+#include <linux/task_struct.h>
+
/* Sparc rules... */
register struct task_struct *current asm("g6");
--- linux-2.5.26-sr1/include/asm-sparc64/current.h Wed Jul 17 01:49:23 2002
+++ linux-2.5.26-sr2/include/asm-sparc64/current.h Fri Jul 19 17:34:37 2002
@@ -1,6 +1,7 @@
#ifndef _SPARC64_CURRENT_H
#define _SPARC64_CURRENT_H
+#include <linux/task_struct.h>
#include <asm/thread_info.h>
register struct task_struct *current asm("g4");
--- linux-2.5.26-sr1/include/asm-x86_64/current.h Wed Jul 17 01:49:24 2002
+++ linux-2.5.26-sr2/include/asm-x86_64/current.h Fri Jul 19 17:34:37 2002
@@ -2,8 +2,8 @@
#define _X86_64_CURRENT_H
#if !defined(__ASSEMBLY__)
-struct task_struct;
+#include <linux/task_struct.h>
#include <asm/pda.h>
static inline struct task_struct *get_current(void)
prev parent reply other threads:[~2002-07-19 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.33.0207191825120.23556-100000@gans.physik3.uni-rostock.de>
2002-07-19 16:55 ` [patch 2/3] fix indirect dependencies on sched.h Tim Schmielau
2002-07-19 17:02 ` Tim Schmielau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.33.0207191856080.23556-100000@gans.physik3.uni-rostock.de \
--to=tim@physik3.uni-rostock.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).