From: Mikael Pettersson <mikpe@csd.uu.se>
To: linux-kernel@vger.kernel.org
Subject: 2.4.0 memory sizing broken on old x86 machines
Date: Sat, 6 Jan 2001 00:22:32 +0100 (MET) [thread overview]
Message-ID: <200101052322.AAA01515@harpo.it.uu.se> (raw)
Memory sizing for old machines whose BIOSen don't speak E820
got broken in 2.4.0-test13-pre4:
--- v2.4.0-test12/linux/arch/i386/kernel/setup.c Mon Dec 11 17:59:43 2000
+++ linux/arch/i386/kernel/setup.c Thu Dec 21 14:01:19 2000
@@ -518,7 +518,7 @@
e820.nr_map = 0;
add_memory_region(0, LOWMEMSIZE(), E820_RAM);
- add_memory_region(HIGH_MEMORY, mem_size << 10, E820_RAM);
+ add_memory_region(HIGH_MEMORY, (mem_size << 10) - HIGH_MEMORY, E820_RAM);
}
printk("BIOS-provided physical RAM map:\n");
print_memory_map(who);
(This snipped is in setup_memory_region() where legacy (e801 or 88)
memory size info is converted to e820-style.)
BIOS call 0x88 returns extended (above 1M) memory size not total, so
the subtraction "- HIGH_MEMORY" is wrong. The effect is that the
kernel believes the machine to have 1MB less RAM than it actually has
-- not fun on an old 486 with limited RAM to start with :-(
I think this patch should be backed out pronto.
/Mikael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
reply other threads:[~2001-01-05 23:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200101052322.AAA01515@harpo.it.uu.se \
--to=mikpe@csd.uu.se \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).