[1/3] Revert "lib/test_sort.c: make it explicitly non-modular"
diff mbox series

Message ID 1488287219-15832-2-git-send-email-geert@linux-m68k.org
State New, archived
Headers show
Series
  • lib: add module support to sort tests
Related show

Commit Message

Geert Uytterhoeven Feb. 28, 2017, 1:06 p.m. UTC
This reverts commit 8893f519330bb073a49c5b4676fce4be6f1be15d.

It's very valuable to have modular tests, so you can run them just by
insmodding the test modules, instead of needing a separate kernel that
runs them at boot.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 lib/test_sort.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

Comments

Andy Shevchenko Feb. 28, 2017, 2:24 p.m. UTC | #1
On Tue, 2017-02-28 at 14:06 +0100, Geert Uytterhoeven wrote:
> This reverts commit 8893f519330bb073a49c5b4676fce4be6f1be15d.
> 
> It's very valuable to have modular tests, so you can run them just by
> insmodding the test modules, instead of needing a separate kernel that
> runs them at boot.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  lib/test_sort.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/test_sort.c b/lib/test_sort.c
> index 4db3911db50ace76..d389c1cc2f6cf795 100644
> --- a/lib/test_sort.c
> +++ b/lib/test_sort.c
> @@ -1,11 +1,8 @@
>  #include <linux/sort.h>
>  #include <linux/slab.h>
> -#include <linux/init.h>
> +#include <linux/module.h>
> 

>  
> -/*
> - * A simple boot-time regression test
> - * License: GPL
> - */
> +/* a simple boot-time regression test */

I would leave this piece as is now.

The rest is okay.

>  
>  #define TEST_LEN 1000
>  
> @@ -41,4 +38,6 @@ static int __init test_sort_init(void)
>  	kfree(a);
>  	return err;
>  }
> -subsys_initcall(test_sort_init);
> +
> +module_init(test_sort_init);
> +MODULE_LICENSE("GPL");
Geert Uytterhoeven Feb. 28, 2017, 3:24 p.m. UTC | #2
Hi Andy,

On Tue, Feb 28, 2017 at 3:24 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Tue, 2017-02-28 at 14:06 +0100, Geert Uytterhoeven wrote:
>> This reverts commit 8893f519330bb073a49c5b4676fce4be6f1be15d.
>>
>> It's very valuable to have modular tests, so you can run them just by
>> insmodding the test modules, instead of needing a separate kernel that
>> runs them at boot.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> ---
>>  lib/test_sort.c | 11 +++++------
>>  1 file changed, 5 insertions(+), 6 deletions(-)
>>
>> diff --git a/lib/test_sort.c b/lib/test_sort.c
>> index 4db3911db50ace76..d389c1cc2f6cf795 100644
>> --- a/lib/test_sort.c
>> +++ b/lib/test_sort.c
>> @@ -1,11 +1,8 @@
>>  #include <linux/sort.h>
>>  #include <linux/slab.h>
>> -#include <linux/init.h>
>> +#include <linux/module.h>
>>
>
>>
>> -/*
>> - * A simple boot-time regression test
>> - * License: GPL
>> - */
>> +/* a simple boot-time regression test */
>
> I would leave this piece as is now.

As this is a revert, I prefer to revert 100%.

> The rest is okay.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Patch
diff mbox series

diff --git a/lib/test_sort.c b/lib/test_sort.c
index 4db3911db50ace76..d389c1cc2f6cf795 100644
--- a/lib/test_sort.c
+++ b/lib/test_sort.c
@@ -1,11 +1,8 @@ 
 #include <linux/sort.h>
 #include <linux/slab.h>
-#include <linux/init.h>
+#include <linux/module.h>
 
-/*
- * A simple boot-time regression test
- * License: GPL
- */
+/* a simple boot-time regression test */
 
 #define TEST_LEN 1000
 
@@ -41,4 +38,6 @@  static int __init test_sort_init(void)
 	kfree(a);
 	return err;
 }
-subsys_initcall(test_sort_init);
+
+module_init(test_sort_init);
+MODULE_LICENSE("GPL");