[v2,16/23] MAINTAINERS: Add file patterns for powerpc device tree bindings
diff mbox series

Message ID 1489324627-19126-17-git-send-email-geert@linux-m68k.org
State New, archived
Headers show
Series
  • MAINTAINERS: Add file patterns for subsystem device tree bindings
Related show

Commit Message

Geert Uytterhoeven March 12, 2017, 1:17 p.m. UTC
Submitters of device tree binding documentation may forget to CC
the subsystem maintainer if this is missing.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
---
Please apply this patch directly if you want to be involved in device
tree binding documentation for your subsystem.

v2:
  - Rebased on top of commit a42715830d552d7c ("MAINTAINERS: Remove
    powerpc's "opal" pattern match), which just added "powerpc/opal",
    while obviously the whole "powerpc" hierarchy is of interest.

Impact on next-20170310:

-Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,commit_signer:11/11=100%)
+Benjamin Herrenschmidt <benh@kernel.crashing.org> (supporter:LINUX FOR POWERPC (32-BIT AND 64-BIT))
+Paul Mackerras <paulus@samba.org> (supporter:LINUX FOR POWERPC (32-BIT AND 64-BIT))
+Michael Ellerman <mpe@ellerman.id.au> (supporter:LINUX FOR POWERPC (32-BIT AND 64-BIT))
+Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
 Mark Rutland <mark.rutland@arm.com> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
-Scott Wood <oss@buserror.net> (commit_signer:5/11=45%)
-Zhao Qiang <qiang.zhao@nxp.com> (commit_signer:4/11=36%,authored:4/11=36%)
-Michael Ellerman <mpe@ellerman.id.au> (commit_signer:3/11=27%)
-Christian Lamparter <chunkeey@googlemail.com> (commit_signer:1/11=9%)
-yangbo lu <yangbo.lu@nxp.com> (authored:1/11=9%)
-"Otto Kekäläinen" <otto@seravo.fi> (authored:1/11=9%)
-Chris Packham <chris.packham@alliedtelesis.co.nz> (authored:1/11=9%)
-York Sun <york.sun@nxp.com> (authored:1/11=9%)
+linuxppc-dev@lists.ozlabs.org (open list:LINUX FOR POWERPC (32-BIT AND 64-BIT))
 devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
 linux-kernel@vger.kernel.org (open list)
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Ellerman March 15, 2017, 12:19 a.m. UTC | #1
Geert Uytterhoeven <geert@linux-m68k.org> writes:

> Submitters of device tree binding documentation may forget to CC
> the subsystem maintainer if this is missing.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: linuxppc-dev@lists.ozlabs.org
> ---
> Please apply this patch directly if you want to be involved in device
> tree binding documentation for your subsystem.
>
> v2:
>   - Rebased on top of commit a42715830d552d7c ("MAINTAINERS: Remove
>     powerpc's "opal" pattern match), which just added "powerpc/opal",
>     while obviously the whole "powerpc" hierarchy is of interest.
>
> Impact on next-20170310:

Actual diff ignoring ordering etc:

 +Benjamin Herrenschmidt <benh@kernel.crashing.org> (supporter:LINUX FOR POWERPC (32-BIT AND 64-BIT))
 +Paul Mackerras <paulus@samba.org> (supporter:LINUX FOR POWERPC (32-BIT AND 64-BIT))
 +linuxppc-dev@lists.ozlabs.org (open list:LINUX FOR POWERPC (32-BIT AND 64-BIT))
 -Scott Wood <oss@buserror.net> (commit_signer:5/11=45%)
 -Zhao Qiang <qiang.zhao@nxp.com> (commit_signer:4/11=36%,authored:4/11=36%)
 -Christian Lamparter <chunkeey@googlemail.com> (commit_signer:1/11=9%)
 -yangbo lu <yangbo.lu@nxp.com> (authored:1/11=9%)
 -"Otto Kekäläinen" <otto@seravo.fi> (authored:1/11=9%)
 -Chris Packham <chris.packham@alliedtelesis.co.nz> (authored:1/11=9%)
 -York Sun <york.sun@nxp.com> (authored:1/11=9%)

Which looks bad as all the NXP folks get dropped, but they should be
reading linuxppc-dev. So I think I'll merge this, unless anyone
disagrees.

cheers
Geert Uytterhoeven March 15, 2017, 8:03 a.m. UTC | #2
Hi Michael,

On Wed, Mar 15, 2017 at 1:19 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Geert Uytterhoeven <geert@linux-m68k.org> writes:
>> Submitters of device tree binding documentation may forget to CC
>> the subsystem maintainer if this is missing.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> Cc: Paul Mackerras <paulus@samba.org>
>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>> Cc: linuxppc-dev@lists.ozlabs.org
>> ---
>> Please apply this patch directly if you want to be involved in device
>> tree binding documentation for your subsystem.
>>
>> v2:
>>   - Rebased on top of commit a42715830d552d7c ("MAINTAINERS: Remove
>>     powerpc's "opal" pattern match), which just added "powerpc/opal",
>>     while obviously the whole "powerpc" hierarchy is of interest.
>>
>> Impact on next-20170310:
>
> Actual diff ignoring ordering etc:
>
>  +Benjamin Herrenschmidt <benh@kernel.crashing.org> (supporter:LINUX FOR POWERPC (32-BIT AND 64-BIT))
>  +Paul Mackerras <paulus@samba.org> (supporter:LINUX FOR POWERPC (32-BIT AND 64-BIT))
>  +linuxppc-dev@lists.ozlabs.org (open list:LINUX FOR POWERPC (32-BIT AND 64-BIT))
>  -Scott Wood <oss@buserror.net> (commit_signer:5/11=45%)
>  -Zhao Qiang <qiang.zhao@nxp.com> (commit_signer:4/11=36%,authored:4/11=36%)
>  -Christian Lamparter <chunkeey@googlemail.com> (commit_signer:1/11=9%)
>  -yangbo lu <yangbo.lu@nxp.com> (authored:1/11=9%)
>  -"Otto Kekäläinen" <otto@seravo.fi> (authored:1/11=9%)
>  -Chris Packham <chris.packham@alliedtelesis.co.nz> (authored:1/11=9%)
>  -York Sun <york.sun@nxp.com> (authored:1/11=9%)
>
> Which looks bad as all the NXP folks get dropped, but they should be
> reading linuxppc-dev. So I think I'll merge this, unless anyone
> disagrees.

They got dropped because in the absence of a maintainer entry, the
last committers are listed. If they need to be listed, I can send patches to add
more specific entries for 4xx and fsl DT bindings, like:

diff --git a/MAINTAINERS b/MAINTAINERS
index 0f1c2f96c99aa936..40b392a4f399adbe 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5266,6 +5266,7 @@ M:        Scott Wood <oss@buserror.net>
 L:     linuxppc-dev@lists.ozlabs.org
 L:     linux-arm-kernel@lists.infradead.org
 S:     Maintained
+F:     Documentation/devicetree/bindings/powerpc/fsl/
 F:     drivers/soc/fsl/
 F:     include/linux/fsl/

@@ -7540,6 +7541,7 @@ M:        Matt Porter <mporter@kernel.crashing.org>
 W:     http://www.penguinppc.org/
 L:     linuxppc-dev@lists.ozlabs.org
 S:     Maintained
+F:     Documentation/devicetree/bindings/powerpc/4xx/
 F:     arch/powerpc/platforms/40x/
 F:     arch/powerpc/platforms/44x/


OK?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Michael Ellerman March 15, 2017, 9:30 a.m. UTC | #3
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> On Wed, Mar 15, 2017 at 1:19 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> Geert Uytterhoeven <geert@linux-m68k.org> writes:
>>> Submitters of device tree binding documentation may forget to CC
>>> the subsystem maintainer if this is missing.
>>>
>>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>> Cc: Paul Mackerras <paulus@samba.org>
>>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>>> Cc: linuxppc-dev@lists.ozlabs.org
>>> ---
>>> Please apply this patch directly if you want to be involved in device
>>> tree binding documentation for your subsystem.
>>>
>>> v2:
>>>   - Rebased on top of commit a42715830d552d7c ("MAINTAINERS: Remove
>>>     powerpc's "opal" pattern match), which just added "powerpc/opal",
>>>     while obviously the whole "powerpc" hierarchy is of interest.
>>>
>>> Impact on next-20170310:
>>
>> Actual diff ignoring ordering etc:
>>
>>  +Benjamin Herrenschmidt <benh@kernel.crashing.org> (supporter:LINUX FOR POWERPC (32-BIT AND 64-BIT))
>>  +Paul Mackerras <paulus@samba.org> (supporter:LINUX FOR POWERPC (32-BIT AND 64-BIT))
>>  +linuxppc-dev@lists.ozlabs.org (open list:LINUX FOR POWERPC (32-BIT AND 64-BIT))
>>  -Scott Wood <oss@buserror.net> (commit_signer:5/11=45%)
>>  -Zhao Qiang <qiang.zhao@nxp.com> (commit_signer:4/11=36%,authored:4/11=36%)
>>  -Christian Lamparter <chunkeey@googlemail.com> (commit_signer:1/11=9%)
>>  -yangbo lu <yangbo.lu@nxp.com> (authored:1/11=9%)
>>  -"Otto Kekäläinen" <otto@seravo.fi> (authored:1/11=9%)
>>  -Chris Packham <chris.packham@alliedtelesis.co.nz> (authored:1/11=9%)
>>  -York Sun <york.sun@nxp.com> (authored:1/11=9%)
>>
>> Which looks bad as all the NXP folks get dropped, but they should be
>> reading linuxppc-dev. So I think I'll merge this, unless anyone
>> disagrees.
>
> They got dropped because in the absence of a maintainer entry, the
> last committers are listed. If they need to be listed, I can send patches to add
> more specific entries for 4xx and fsl DT bindings, like:

This is one is probably worth doing:

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0f1c2f96c99aa936..40b392a4f399adbe 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5266,6 +5266,7 @@ M:        Scott Wood <oss@buserror.net>
>  L:     linuxppc-dev@lists.ozlabs.org
>  L:     linux-arm-kernel@lists.infradead.org
>  S:     Maintained
> +F:     Documentation/devicetree/bindings/powerpc/fsl/
>  F:     drivers/soc/fsl/
>  F:     include/linux/fsl/

I'll fold it in before applying?

But I wouldn't bother with 4xx, just falling back to linuxppc-dev is
fine for that.

> @@ -7540,6 +7541,7 @@ M:        Matt Porter <mporter@kernel.crashing.org>
>  W:     http://www.penguinppc.org/
>  L:     linuxppc-dev@lists.ozlabs.org
>  S:     Maintained
> +F:     Documentation/devicetree/bindings/powerpc/4xx/
>  F:     arch/powerpc/platforms/40x/
>  F:     arch/powerpc/platforms/44x/

cheers
Geert Uytterhoeven March 15, 2017, 9:36 a.m. UTC | #4
Hi Michael,

On Wed, Mar 15, 2017 at 10:30 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Geert Uytterhoeven <geert@linux-m68k.org> writes:
>> On Wed, Mar 15, 2017 at 1:19 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>>> Geert Uytterhoeven <geert@linux-m68k.org> writes:
>>>> Submitters of device tree binding documentation may forget to CC
>>>> the subsystem maintainer if this is missing.
>>>>
>>>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>>> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>>> Cc: Paul Mackerras <paulus@samba.org>
>>>> Cc: Michael Ellerman <mpe@ellerman.id.au>
>>>> Cc: linuxppc-dev@lists.ozlabs.org
>>>> ---
>>>> Please apply this patch directly if you want to be involved in device
>>>> tree binding documentation for your subsystem.
>>>>
>>>> v2:
>>>>   - Rebased on top of commit a42715830d552d7c ("MAINTAINERS: Remove
>>>>     powerpc's "opal" pattern match), which just added "powerpc/opal",
>>>>     while obviously the whole "powerpc" hierarchy is of interest.
>>>>
>>>> Impact on next-20170310:
>>>
>>> Actual diff ignoring ordering etc:
>>>
>>>  +Benjamin Herrenschmidt <benh@kernel.crashing.org> (supporter:LINUX FOR POWERPC (32-BIT AND 64-BIT))
>>>  +Paul Mackerras <paulus@samba.org> (supporter:LINUX FOR POWERPC (32-BIT AND 64-BIT))
>>>  +linuxppc-dev@lists.ozlabs.org (open list:LINUX FOR POWERPC (32-BIT AND 64-BIT))
>>>  -Scott Wood <oss@buserror.net> (commit_signer:5/11=45%)
>>>  -Zhao Qiang <qiang.zhao@nxp.com> (commit_signer:4/11=36%,authored:4/11=36%)
>>>  -Christian Lamparter <chunkeey@googlemail.com> (commit_signer:1/11=9%)
>>>  -yangbo lu <yangbo.lu@nxp.com> (authored:1/11=9%)
>>>  -"Otto Kekäläinen" <otto@seravo.fi> (authored:1/11=9%)
>>>  -Chris Packham <chris.packham@alliedtelesis.co.nz> (authored:1/11=9%)
>>>  -York Sun <york.sun@nxp.com> (authored:1/11=9%)
>>>
>>> Which looks bad as all the NXP folks get dropped, but they should be
>>> reading linuxppc-dev. So I think I'll merge this, unless anyone
>>> disagrees.
>>
>> They got dropped because in the absence of a maintainer entry, the
>> last committers are listed. If they need to be listed, I can send patches to add
>> more specific entries for 4xx and fsl DT bindings, like:
>
> This is one is probably worth doing:
>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 0f1c2f96c99aa936..40b392a4f399adbe 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -5266,6 +5266,7 @@ M:        Scott Wood <oss@buserror.net>
>>  L:     linuxppc-dev@lists.ozlabs.org
>>  L:     linux-arm-kernel@lists.infradead.org
>>  S:     Maintained
>> +F:     Documentation/devicetree/bindings/powerpc/fsl/
>>  F:     drivers/soc/fsl/
>>  F:     include/linux/fsl/
>
> I'll fold it in before applying?

Fine (less work) for me! Thanks!

> But I wouldn't bother with 4xx, just falling back to linuxppc-dev is
> fine for that.

OK.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Michael Ellerman March 21, 2017, 11:36 a.m. UTC | #5
On Sun, 2017-03-12 at 13:17:00 UTC, Geert Uytterhoeven wrote:
> Submitters of device tree binding documentation may forget to CC
> the subsystem maintainer if this is missing.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: linuxppc-dev@lists.ozlabs.org

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/58f169139e9692e290a7d5d9b034b7

cheers

Patch
diff mbox series

diff --git a/MAINTAINERS b/MAINTAINERS
index 896d7238f3f3f4e5..551ab8e4b771bcc2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7494,7 +7494,7 @@  Q:	http://patchwork.ozlabs.org/project/linuxppc-dev/list/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git
 S:	Supported
 F:	Documentation/ABI/stable/sysfs-firmware-opal-*
-F:	Documentation/devicetree/bindings/powerpc/opal/
+F:	Documentation/devicetree/bindings/powerpc/
 F:	Documentation/devicetree/bindings/rtc/rtc-opal.txt
 F:	Documentation/devicetree/bindings/i2c/i2c-opal.txt
 F:	Documentation/powerpc/