From: Daniel Baluta <daniel.baluta@nxp.com>
To: <nicoleotsuka@gmail.com>, <broonie@kernel.org>,
<alsa-devel@alsa-project.org>
Cc: <timur@tabi.org>, <Xiubo.Lee@gmail.com>, <fabio.estevam@nxp.com>,
<lgirdwood@gmail.com>, <perex@perex.cz>, <tiwai@suse.com>,
<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup
Date: Tue, 28 Mar 2017 11:58:52 +0300 [thread overview]
Message-ID: <1490691532-2086-3-git-send-email-daniel.baluta@nxp.com> (raw)
In-Reply-To: <1490691532-2086-1-git-send-email-daniel.baluta@nxp.com>
Resource managed devm_clk_get only works with platform's device dev.
Reported-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
---
sound/soc/fsl/imx-wm8962.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/fsl/imx-wm8962.c b/sound/soc/fsl/imx-wm8962.c
index 3d894d9..52659fa 100644
--- a/sound/soc/fsl/imx-wm8962.c
+++ b/sound/soc/fsl/imx-wm8962.c
@@ -231,7 +231,7 @@ static int imx_wm8962_probe(struct platform_device *pdev)
goto fail;
}
- codec_clk = devm_clk_get(&codec_dev->dev, NULL);
+ codec_clk = clk_get(&codec_dev->dev, NULL);
if (IS_ERR(codec_clk)) {
ret = PTR_ERR(codec_clk);
dev_err(&codec_dev->dev, "failed to get codec clk: %d\n", ret);
@@ -239,6 +239,7 @@ static int imx_wm8962_probe(struct platform_device *pdev)
}
data->clk_frequency = clk_get_rate(codec_clk);
+ clk_put(codec_clk);
data->dai.name = "HiFi";
data->dai.stream_name = "HiFi";
--
2.7.4
next prev parent reply other threads:[~2017-03-28 8:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 8:58 [PATCH v3 0/2] imx-wm8962: Let codec driver enable/disable its MCLK Daniel Baluta
2017-03-28 8:58 ` [PATCH v3 1/2] ASoC: " Daniel Baluta
2017-03-28 8:58 ` Daniel Baluta [this message]
2017-03-28 9:21 ` [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup Charles Keepax
2017-03-28 10:47 ` Daniel Baluta
2017-03-28 11:53 ` Charles Keepax
2017-03-28 15:24 ` Mark Brown
2017-03-28 15:42 ` Charles Keepax
2017-03-29 11:38 ` Daniel Baluta
2017-03-29 11:47 ` Mark Brown
2017-03-29 11:54 ` Applied "ASoC: imx-wm8962: Fix codec_clk cleanup" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490691532-2086-3-git-send-email-daniel.baluta@nxp.com \
--to=daniel.baluta@nxp.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=timur@tabi.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).