From: Christopher Bostic <cbostic@linux.vnet.ibm.com>
To: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
rostedt@goodmis.org, mingo@redhat.com,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Jeremy Kerr <jk@ozlabs.org>,
joel@jms.id.au, linux-kernel@vger.kernel.org, andrew@aj.id.au,
alistair@popple.id.au, benh@kernel.crashing.org,
Chris Bostic <cbostic@linux.vnet.ibm.com>
Subject: [PATCH v5 14/23] drivers/fsi: Add sysfs files for FSI master & slave accesses
Date: Tue, 4 Apr 2017 21:05:58 -0500 [thread overview]
Message-ID: <20170405020607.79939-15-cbostic@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170405020607.79939-1-cbostic@linux.vnet.ibm.com>
From: Jeremy Kerr <jk@ozlabs.org>
This change adds a 'raw' file for reads & writes, and a 'term' file for
the TERM command, and a 'break' file for issuing a BREAK.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Chris Bostic <cbostic@linux.vnet.ibm.com>
---
drivers/fsi/fsi-core.c | 116 +++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 116 insertions(+)
diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
index 4359e26..f0f0556 100644
--- a/drivers/fsi/fsi-core.c
+++ b/drivers/fsi/fsi-core.c
@@ -294,6 +294,95 @@ static int fsi_slave_scan(struct fsi_slave *slave)
return 0;
}
+static ssize_t fsi_slave_sysfs_raw_read(struct file *file,
+ struct kobject *kobj, struct bin_attribute *attr, char *buf,
+ loff_t off, size_t count)
+{
+ struct fsi_slave *slave = to_fsi_slave(kobj_to_dev(kobj));
+ size_t total_len, read_len;
+ int rc;
+
+ if (off < 0)
+ return -EINVAL;
+
+ if (off > 0xffffffff || count > 0xffffffff || off + count > 0xffffffff)
+ return -EINVAL;
+
+ for (total_len = 0; total_len < count; total_len += read_len) {
+ read_len = min_t(size_t, count, 4);
+ read_len -= off & 0x3;
+
+ rc = fsi_slave_read(slave, off, buf + total_len, read_len);
+ if (rc)
+ return rc;
+
+ off += read_len;
+ }
+
+ return count;
+}
+
+static ssize_t fsi_slave_sysfs_raw_write(struct file *file,
+ struct kobject *kobj, struct bin_attribute *attr,
+ char *buf, loff_t off, size_t count)
+{
+ struct fsi_slave *slave = to_fsi_slave(kobj_to_dev(kobj));
+ size_t total_len, write_len;
+ int rc;
+
+ if (off < 0)
+ return -EINVAL;
+
+ if (off > 0xffffffff || count > 0xffffffff || off + count > 0xffffffff)
+ return -EINVAL;
+
+ for (total_len = 0; total_len < count; total_len += write_len) {
+ write_len = min_t(size_t, count, 4);
+ write_len -= off & 0x3;
+
+ rc = fsi_slave_write(slave, off, buf + total_len, write_len);
+ if (rc)
+ return rc;
+
+ off += write_len;
+ }
+
+ return count;
+}
+
+static struct bin_attribute fsi_slave_raw_attr = {
+ .attr = {
+ .name = "raw",
+ .mode = 0600,
+ },
+ .size = 0,
+ .read = fsi_slave_sysfs_raw_read,
+ .write = fsi_slave_sysfs_raw_write,
+};
+
+static ssize_t fsi_slave_sysfs_term_write(struct file *file,
+ struct kobject *kobj, struct bin_attribute *attr,
+ char *buf, loff_t off, size_t count)
+{
+ struct fsi_slave *slave = to_fsi_slave(kobj_to_dev(kobj));
+ struct fsi_master *master = slave->master;
+
+ if (!master->term)
+ return -ENODEV;
+
+ master->term(master, slave->link, slave->id);
+ return count;
+}
+
+static struct bin_attribute fsi_slave_term_attr = {
+ .attr = {
+ .name = "term",
+ .mode = 0200,
+ },
+ .size = 0,
+ .write = fsi_slave_sysfs_term_write,
+};
+
/* Encode slave local bus echo delay */
static inline uint32_t fsi_smode_echodly(int x)
{
@@ -409,6 +498,14 @@ static int fsi_slave_init(struct fsi_master *master, int link, uint8_t id)
return rc;
}
+ rc = device_create_bin_file(&slave->dev, &fsi_slave_raw_attr);
+ if (rc)
+ dev_warn(&slave->dev, "failed to create raw attr: %d\n", rc);
+
+ rc = device_create_bin_file(&slave->dev, &fsi_slave_term_attr);
+ if (rc)
+ dev_warn(&slave->dev, "failed to create term attr: %d\n", rc);
+
fsi_slave_scan(slave);
return 0;
}
@@ -523,6 +620,18 @@ static ssize_t master_rescan_store(struct device *dev,
static DEVICE_ATTR(rescan, 0200, NULL, master_rescan_store);
+static ssize_t master_break_store(struct device *dev,
+ struct device_attribute *attr, const char *buf, size_t count)
+{
+ struct fsi_master *master = to_fsi_master(dev);
+
+ fsi_master_break(master, 0);
+
+ return count;
+}
+
+static DEVICE_ATTR(break, 0200, NULL, master_break_store);
+
int fsi_master_register(struct fsi_master *master)
{
int rc;
@@ -546,6 +655,13 @@ int fsi_master_register(struct fsi_master *master)
return rc;
}
+ rc = device_create_file(&master->dev, &dev_attr_break);
+ if (rc) {
+ device_unregister(&master->dev);
+ ida_simple_remove(&master_ida, master->idx);
+ return rc;
+ }
+
fsi_master_scan(master);
return 0;
--
1.8.2.2
next prev parent reply other threads:[~2017-04-05 2:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 2:05 [PATCH v5 00/23] FSI device driver implementation Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 01/23] drivers/fsi: Add fsi master definition Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 02/23] drivers/fsi: Add slave definition Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 03/23] drivers/fsi: Add empty master scan Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 04/23] drivers/fsi: Add crc4 helpers Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 05/23] drivers/fsi: Add slave & master read/write APIs Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 06/23] drivers/fsi: Set up links for slave communication Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 07/23] drivers/fsi: Implement slave initialisation Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 08/23] drivers/fsi: Set slave SMODE to init communication Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 09/23] drivers/fsi: scan slaves & register devices Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 10/23] drivers/fsi: Add device read/write/peek API Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 11/23] drivers/fsi: Add master unscan Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 12/23] drivers/fsi: Add documentation for GPIO bindings Christopher Bostic
2017-04-05 2:05 ` [PATCH v5 13/23] drivers/fsi: Add client driver register utilities Christopher Bostic
2017-04-05 2:05 ` Christopher Bostic [this message]
2017-04-05 2:05 ` [PATCH v5 15/23] drivers/fsi: expose direct-access slave API Christopher Bostic
2017-04-05 2:06 ` [PATCH v5 16/23] drivers/fsi: Add tracepoints for low-level operations Christopher Bostic
2017-04-05 2:06 ` [PATCH v5 17/23] drivers/fsi: Add error handling for slave communication errors Christopher Bostic
2017-04-05 2:06 ` [PATCH v5 18/23] drivers/fsi: Document FSI master sysfs files in ABI Christopher Bostic
2017-04-05 2:06 ` [PATCH v5 19/23] drivers/fsi: Add GPIO based FSI master Christopher Bostic
2017-04-05 16:35 ` Randy Dunlap
2017-04-09 21:04 ` Christopher Bostic
2017-04-05 2:06 ` [PATCH v5 20/23] drivers/fsi/gpio: Add tracepoints for GPIO master Christopher Bostic
2017-04-05 2:06 ` [PATCH v5 21/23] drivers/fsi: Add SCOM FSI client device driver Christopher Bostic
2017-04-05 16:35 ` Randy Dunlap
2017-04-09 21:06 ` Christopher Bostic
2017-04-05 2:06 ` [PATCH v5 22/23] drivers/fsi: Add hub master support Christopher Bostic
2017-04-05 16:36 ` Randy Dunlap
2017-04-09 21:07 ` Christopher Bostic
2017-04-05 2:06 ` [PATCH v5 23/23] drivers/fsi: Use asynchronous slave mode Christopher Bostic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405020607.79939-15-cbostic@linux.vnet.ibm.com \
--to=cbostic@linux.vnet.ibm.com \
--cc=alistair@popple.id.au \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).