linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Adam J. Richter" <adam@yggdrasil.com>
To: andrea@suse.de, linux-kernel@vger.kernel.org
Subject: Patch?: initial ramdisks did not work in 2.5.28-29
Date: Sun, 28 Jul 2002 16:42:20 -0700	[thread overview]
Message-ID: <200207282342.QAA03809@adam.yggdrasil.com> (raw)

	Initial ramdisks do not work in linux-2.5.2{8,9}, because
fs/block_dev.c in these kernels has a new version of bd_open()
that does not set bdev->bd_inode->i_size when bdev->bd_openers is
non-zero.

	I would appreciate information on whether this change in
bd_open's behavior is intended.  If it is, then the following
patch makes updates the ramdisk driver to work again.

	Also, I would appreciate knowing if anyone is acting as
maintainer for drivers/block/rd.c, or if I should just send
patches for rd.c directly to Linus if nobody complains on
the linux-kernel mailing list.  I have some other minor patches for rd.c
to reduce its use of minor device numbers, and a patch that someone
whose name I don't remember posted long ago for dropping pages that
contiain all zeroes.

Adam J. Richter     __     ______________   575 Oroville Road
adam@yggdrasil.com     \ /                  Milpitas, California 95035
+1 408 309-6081         | g g d r a s i l   United States of America
                         "Free Software For The Rest Of Us."

--- linux-2.5.29/drivers/block/rd.c	2002-07-26 19:58:39.000000000 -0700
+++ linux/drivers/block/rd.c	2002-07-28 16:28:03.000000000 -0700
@@ -379,6 +404,7 @@
 		rd_bdev[unit]->bd_openers++;
 		rd_bdev[unit]->bd_block_size = rd_blocksize;
 		rd_bdev[unit]->bd_inode->i_mapping->a_ops = &ramdisk_aops;
+		rd_bdev[unit]->bd_inode->i_size = rd_kbsize[unit] << 10;
 		rd_bdev[unit]->bd_queue = &blk_dev[MAJOR_NR].request_queue;
 	}
 

             reply	other threads:[~2002-07-28 23:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-28 23:42 Adam J. Richter [this message]
2002-07-28 23:51 ` Patch?: initial ramdisks did not work in 2.5.28-29 Russell King
2002-07-29  0:17 Adam J. Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200207282342.QAA03809@adam.yggdrasil.com \
    --to=adam@yggdrasil.com \
    --cc=andrea@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).