mtd: dataflash: Use ULL suffix for 64-bit constants
diff mbox series

Message ID 1500105555-14074-1-git-send-email-geert@linux-m68k.org
State New, archived
Headers show
Series
  • mtd: dataflash: Use ULL suffix for 64-bit constants
Related show

Commit Message

Geert Uytterhoeven July 15, 2017, 7:59 a.m. UTC
With gcc 4.1.2:

    drivers/mtd/devices/mtd_dataflash.c:740: warning: integer constant is too large for ‘long’ type
    drivers/mtd/devices/mtd_dataflash.c:741: warning: integer constant is too large for ‘long’ type

Add the missing "ULL" suffix to fix this.

Fixes: 67e4145ebf2c161d ("mtd: dataflash: Add flash_info for AT45DB641E")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/mtd/devices/mtd_dataflash.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Andrey Smirnov July 27, 2017, 12:34 a.m. UTC | #1
On Sat, Jul 15, 2017 at 12:59 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> With gcc 4.1.2:
>
>     drivers/mtd/devices/mtd_dataflash.c:740: warning: integer constant is too large for ‘long’ type
>     drivers/mtd/devices/mtd_dataflash.c:741: warning: integer constant is too large for ‘long’ type
>
> Add the missing "ULL" suffix to fix this.
>
> Fixes: 67e4145ebf2c161d ("mtd: dataflash: Add flash_info for AT45DB641E")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

My bad, sorry about that. FWIW,

Acked-by: Andrey Smirnov <andrew.smirnov@gmail.com>

> ---
>  drivers/mtd/devices/mtd_dataflash.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
> index 5dc8bd042cc54b2d..504e34f295180fd9 100644
> --- a/drivers/mtd/devices/mtd_dataflash.c
> +++ b/drivers/mtd/devices/mtd_dataflash.c
> @@ -737,8 +737,8 @@ static struct flash_info dataflash_data[] = {
>         { "AT45DB642x",  0x1f2800, 8192, 1056, 11, SUP_POW2PS},
>         { "at45db642d",  0x1f2800, 8192, 1024, 10, SUP_POW2PS | IS_POW2PS},
>
> -       { "AT45DB641E",  0x1f28000100, 32768, 264, 9, SUP_EXTID | SUP_POW2PS},
> -       { "at45db641e",  0x1f28000100, 32768, 256, 8, SUP_EXTID | SUP_POW2PS | IS_POW2PS},
> +       { "AT45DB641E",  0x1f28000100ULL, 32768, 264, 9, SUP_EXTID | SUP_POW2PS},
> +       { "at45db641e",  0x1f28000100ULL, 32768, 256, 8, SUP_EXTID | SUP_POW2PS | IS_POW2PS},
>  };
>
>  static struct flash_info *jedec_lookup(struct spi_device *spi,
> --
> 2.7.4
>

Patch
diff mbox series

diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c
index 5dc8bd042cc54b2d..504e34f295180fd9 100644
--- a/drivers/mtd/devices/mtd_dataflash.c
+++ b/drivers/mtd/devices/mtd_dataflash.c
@@ -737,8 +737,8 @@  static struct flash_info dataflash_data[] = {
 	{ "AT45DB642x",  0x1f2800, 8192, 1056, 11, SUP_POW2PS},
 	{ "at45db642d",  0x1f2800, 8192, 1024, 10, SUP_POW2PS | IS_POW2PS},
 
-	{ "AT45DB641E",  0x1f28000100, 32768, 264, 9, SUP_EXTID | SUP_POW2PS},
-	{ "at45db641e",  0x1f28000100, 32768, 256, 8, SUP_EXTID | SUP_POW2PS | IS_POW2PS},
+	{ "AT45DB641E",  0x1f28000100ULL, 32768, 264, 9, SUP_EXTID | SUP_POW2PS},
+	{ "at45db641e",  0x1f28000100ULL, 32768, 256, 8, SUP_EXTID | SUP_POW2PS | IS_POW2PS},
 };
 
 static struct flash_info *jedec_lookup(struct spi_device *spi,