linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nigel Gamble <nigel@mvista.com>
To: jeremy@goop.org
Cc: linux-kernel@vger.kernel.org
Subject: Locking problem in autofs4_expire(), 2.4.0-test10
Date: Fri, 3 Nov 2000 17:57:45 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.21.0011031752150.14843-100000@pegasus.mvista.com> (raw)

dput() is called with dcache_lock already held, resulting in deadlock.

Here is a suggested fix:

===== expire.c 1.3 vs edited =====
--- 1.3/linux/fs/autofs4/expire.c       Tue Oct 31 15:14:06 2000
+++ edited/expire.c     Fri Nov  3 17:47:47 2000
@@ -223,8 +223,10 @@
                        mntput(p);
                        return dentry;
                }
+               spin_unlock(&dcache_lock);
                dput(d);
                mntput(p);
+               spin_lock(&dcache_lock);
        }
        spin_unlock(&dcache_lock);

Nigel Gamble
MontaVista Software

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

             reply	other threads:[~2000-11-04  1:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-11-04  1:57 Nigel Gamble [this message]
2000-11-06  0:34 ` Locking problem in autofs4_expire(), 2.4.0-test10 Nigel Gamble

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.21.0011031752150.14843-100000@pegasus.mvista.com \
    --to=nigel@mvista.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).