[v2] m68k: Restore symbol versions for symbols exported from assembly
diff mbox series

Message ID 1500966575-4136-1-git-send-email-geert@linux-m68k.org
State New, archived
Headers show
Series
  • [v2] m68k: Restore symbol versions for symbols exported from assembly
Related show

Commit Message

Geert Uytterhoeven July 25, 2017, 7:09 a.m. UTC
From: Ben Hutchings <ben@decadent.org.uk>

WARNING: EXPORT symbol "__divsi3" [vmlinux] version generation failed, symbol will not be versioned.
WARNING: EXPORT symbol "__umodsi3" [vmlinux] version generation failed, symbol will not be versioned.
WARNING: EXPORT symbol "__mulsi3" [vmlinux] version generation failed, symbol will not be versioned.
WARNING: EXPORT symbol "__modsi3" [vmlinux] version generation failed, symbol will not be versioned.
WARNING: EXPORT symbol "__udivsi3" [vmlinux] version generation failed, symbol will not be versioned.

Add <asm/asm-prototypes.h> so that genksyms knows the types of these
symbols and can generate CRCs for them.

Fixes: d13ffb563044 ("m68k: move exports to definitions"
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
[geert: Add warning messages, match actual prototypes]
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Based on gccint.info

Several prototypes in the kernel disagree w.r.t. signedness of the
second parameter, and use e.g.

    signed int __divsi3(signed int, unsigned int);

v2:
  - Add warning messages, match actual prototypes.
---
 arch/m68k/include/asm/asm-prototypes.h | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 arch/m68k/include/asm/asm-prototypes.h

Comments

Geert Uytterhoeven Aug. 21, 2017, 9:59 a.m. UTC | #1
On Tue, Jul 25, 2017 at 9:09 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> From: Ben Hutchings <ben@decadent.org.uk>
>
> WARNING: EXPORT symbol "__divsi3" [vmlinux] version generation failed, symbol will not be versioned.
> WARNING: EXPORT symbol "__umodsi3" [vmlinux] version generation failed, symbol will not be versioned.
> WARNING: EXPORT symbol "__mulsi3" [vmlinux] version generation failed, symbol will not be versioned.
> WARNING: EXPORT symbol "__modsi3" [vmlinux] version generation failed, symbol will not be versioned.
> WARNING: EXPORT symbol "__udivsi3" [vmlinux] version generation failed, symbol will not be versioned.
>
> Add <asm/asm-prototypes.h> so that genksyms knows the types of these
> symbols and can generate CRCs for them.
>
> Fixes: d13ffb563044 ("m68k: move exports to definitions"
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> [geert: Add warning messages, match actual prototypes]
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thank you, applied and queued for v4.14.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Patch
diff mbox series

diff --git a/arch/m68k/include/asm/asm-prototypes.h b/arch/m68k/include/asm/asm-prototypes.h
new file mode 100644
index 0000000000000000..22ccb9c975767201
--- /dev/null
+++ b/arch/m68k/include/asm/asm-prototypes.h
@@ -0,0 +1,5 @@ 
+extern int __divsi3(int, int);
+extern int __modsi3(int, int);
+extern int __mulsi3(int, int);
+extern unsigned int __udivsi3(unsigned int, unsigned int);
+extern unsigned int __umodsi3(unsigned int, unsigned int);