From: David Wu <david.wu@rock-chips.com>
To: davem@davemloft.net, heiko@sntech.de, andrew@lunn.ch,
f.fainelli@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
catalin.marinas@arm.com, will.deacon@arm.com, olof@lixom.net,
linux@armlinux.org.uk, arnd@arndb.de
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
huangtao@rock-chips.com, hwg@rock-chips.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, David Wu <david.wu@rock-chips.com>
Subject: [PATCH v3 04/11] net: stmmac: dwmac-rk: Remove unwanted code for rk3328_set_to_rmii()
Date: Wed, 2 Aug 2017 14:15:39 +0800 [thread overview]
Message-ID: <1501654546-17292-5-git-send-email-david.wu@rock-chips.com> (raw)
In-Reply-To: <1501654546-17292-1-git-send-email-david.wu@rock-chips.com>
This is wrong setting for rk3328_set_to_rmii(), so remove it.
Signed-off-by: David Wu <david.wu@rock-chips.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
index f0df519..a8e8fd5 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
@@ -365,9 +365,6 @@ static void rk3328_set_to_rmii(struct rk_priv_data *bsp_priv)
regmap_write(bsp_priv->grf, RK3328_GRF_MAC_CON1,
RK3328_GMAC_PHY_INTF_SEL_RMII |
RK3328_GMAC_RMII_MODE);
-
- /* set MAC to RMII mode */
- regmap_write(bsp_priv->grf, RK3328_GRF_MAC_CON1, GRF_BIT(11));
}
static void rk3328_set_rgmii_speed(struct rk_priv_data *bsp_priv, int speed)
--
1.9.1
next prev parent reply other threads:[~2017-08-02 6:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 6:15 [PATCH v3 00/11] Add the internal phy support David Wu
2017-08-02 6:15 ` [PATCH v3 01/11] net: phy: Add rockchip phy driver support David Wu
2017-08-02 6:20 ` Corentin Labbe
2017-08-02 13:21 ` Andrew Lunn
2017-08-09 7:01 ` David.Wu
2017-08-02 6:15 ` [PATCH v3 02/11] multi_v7_defconfig: Make rockchip phy built-in David Wu
2017-08-02 6:15 ` [PATCH v3 03/11] arm64: defconfig: Enable CONFIG_ROCKCHIP_PHY David Wu
2017-08-02 6:15 ` David Wu [this message]
2017-08-02 6:21 ` [PATCH v3 05/11] net: stmmac: dwmac-rk: Add internal phy support David Wu
2017-08-02 17:38 ` Florian Fainelli
2017-08-03 11:06 ` Chen-Yu Tsai
2017-08-09 8:45 ` Corentin Labbe
2017-08-09 9:38 ` David.Wu
2017-08-10 2:40 ` Chen-Yu Tsai
2017-08-10 7:48 ` David.Wu
2017-08-09 22:42 ` Florian Fainelli
2017-08-03 14:02 ` David.Wu
2017-08-02 6:22 ` [PATCH v3 06/11] net: stmmac: dwmac-rk: Add internal phy support for rk3228 David Wu
2017-08-02 6:23 ` [PATCH v3 07/11] net: stmmac: dwmac-rk: Add internal phy supprot for rk3328 David Wu
2017-08-02 6:23 ` [PATCH v3 08/11] ARM: dts: rk322x: Add support internal phy for gmac David Wu
2017-08-02 6:24 ` [PATCH v3 09/11] ARM: dts: rk3228-evb: Enable the " David Wu
2017-08-02 6:24 ` [PATCH v3 10/11] ARM64: dts: rockchip: Add gmac2phy node support for rk3328 David Wu
2017-08-02 11:49 ` Sergei Shtylyov
2017-08-02 17:40 ` Florian Fainelli
2017-08-02 6:26 ` [PATCH v3 11/11] ARM64: dts: rockchip: Enable gmac2phy for rk3328-evb David Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501654546-17292-5-git-send-email-david.wu@rock-chips.com \
--to=david.wu@rock-chips.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=hwg@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).