From: Pavel Machek <pavel@ucw.cz>
To: chenhc@lemote.com, ralf@linux-mips.org, linux-kernel@vger.kernel.org
Subject: drivers/platform/mips/cpu_hwmon.c: orderly_poweroff() is silent
Date: Sat, 23 Sep 2017 21:11:02 +0200 [thread overview]
Message-ID: <20170923191057.GA17434@amd> (raw)
[-- Attachment #1: Type: text/plain, Size: 744 bytes --]
Orderly poweroff is silent, so it would be nice to
pr_alert("something") at the place of FIXME.
Thanks,
Pavel
diff --git a/drivers/platform/mips/cpu_hwmon.c b/drivers/platform/mips/cpu_hwmon.c
index 322de58..df24292 100644
--- a/drivers/platform/mips/cpu_hwmon.c
+++ b/drivers/platform/mips/cpu_hwmon.c
@@ -147,6 +147,7 @@ static void do_thermal_timer(struct work_struct *work)
if (temp_max <= CPU_THERMAL_THRESHOLD)
schedule_delayed_work(&thermal_work, msecs_to_jiffies(5000));
else
+ /* FIXME: printk message about what is going on */
orderly_poweroff(true);
}
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
reply other threads:[~2017-09-23 19:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170923191057.GA17434@amd \
--to=pavel@ucw.cz \
--cc=chenhc@lemote.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).