From: Anand Moon <linux.amoon@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Lee Jones <lee.jones@linaro.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Anand Moon <linux.amoon@gmail.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk
Date: Fri, 6 Oct 2017 04:36:35 +0000 [thread overview]
Message-ID: <1507264595-3565-2-git-send-email-linux.amoon@gmail.com> (raw)
In-Reply-To: <1507264595-3565-1-git-send-email-linux.amoon@gmail.com>
remove the disable and enable of phy clk.
phy clk is needed to tune the phy controller.
Before:
mout_usbd300 1 1 24000000 0 0
dout_usbd300 0 0 24000000 0 0
sclk_usbd300 0 0 24000000 0 0
dout_usbphy300 1 1 24000000 0 0
sclk_usbphy300 3 3 24000000 0 0
mout_usbd301 1 1 24000000 0 0
dout_usbd301 0 0 24000000 0 0
sclk_usbd301 0 0 24000000 0 0
dout_usbphy301 1 1 24000000 0 0
sclk_usbphy301 2 2 24000000 0 0
After:
mout_usbd300 2 2 24000000 0 0
dout_usbd300 1 1 24000000 0 0
sclk_usbd300 2 2 24000000 0 0
dout_usbphy300 1 1 24000000 0 0
sclk_usbphy300 3 3 24000000 0 0
mout_usbd301 2 2 24000000 0 0
dout_usbd301 1 1 24000000 0 0
sclk_usbd301 2 2 24000000 0 0
dout_usbphy301 1 1 24000000 0 0
sclk_usbphy301 2 2 24000000 0 0
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
drivers/phy/samsung/phy-exynos5-usbdrd.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c
index 22c68f5..5e8054c 100644
--- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
+++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
@@ -409,22 +409,15 @@ static int exynos5_usbdrd_phy_init(struct phy *phy)
reg &= ~PHYCLKRST_PORTRESET;
writel(reg, phy_drd->reg_phy + EXYNOS5_DRD_PHYCLKRST);
- clk_disable_unprepare(phy_drd->clk);
-
return 0;
}
static int exynos5_usbdrd_phy_exit(struct phy *phy)
{
- int ret;
u32 reg;
struct phy_usb_instance *inst = phy_get_drvdata(phy);
struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst);
- ret = clk_prepare_enable(phy_drd->clk);
- if (ret)
- return ret;
-
reg = PHYUTMI_OTGDISABLE |
PHYUTMI_FORCESUSPEND |
PHYUTMI_FORCESLEEP;
--
2.7.4
next prev parent reply other threads:[~2017-10-06 4:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 4:36 [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk Anand Moon
2017-10-06 4:36 ` Anand Moon [this message]
2017-10-06 6:42 ` [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk Krzysztof Kozlowski
2017-10-08 12:41 ` Anand Moon
2017-10-08 15:50 ` Krzysztof Kozlowski
2017-10-08 21:07 ` Anand Moon
2017-10-09 15:16 ` Anand Moon
2017-10-09 16:59 ` Krzysztof Kozlowski
2017-10-09 16:34 ` Krzysztof Kozlowski
2017-10-06 6:38 ` [RFC 1/2] ARM: dts: exynos: update the usbdrd phy and ref clk Krzysztof Kozlowski
2017-10-08 12:36 ` Anand Moon
2017-10-08 15:47 ` Krzysztof Kozlowski
2017-10-08 21:06 ` Anand Moon
2017-10-09 17:05 ` Krzysztof Kozlowski
2017-10-10 6:27 ` Vivek Gautam
2017-10-11 5:46 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507264595-3565-2-git-send-email-linux.amoon@gmail.com \
--to=linux.amoon@gmail.com \
--cc=andrzej.p@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=kishon@ti.com \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).