From: Nick Desaulniers <nick.desaulniers@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: behanw@converseincode.com, dl9pf@gmx.de, charlebm@gmail.com,
mka@chromium.org, ghackmann@google.com, md@google.com,
Nick Desaulniers <nick.desaulniers@gmail.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <mmarek@suse.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] kbuild: clang: remove crufty HOSTCFLAGS
Date: Sat, 7 Oct 2017 13:23:23 -0700 [thread overview]
Message-ID: <20171007202323.1993-1-nick.desaulniers@gmail.com> (raw)
In-Reply-To: <CAK7LNARTo+esxqmoLrXufRoP7qbJprwVOYiRB-a2jRd=AZ0sXg@mail.gmail.com>
When compiling with `make CC=clang HOSTCC=clang`, I was seeing warnings
that clang did not recognize -fno-delete-null-pointer-checks for HOSTCC
targets. These were added in commit 61163efae020 ("kbuild: LLVMLinux:
Add Kbuild support for building kernel with Clang").
Clang does not support -fno-delete-null-pointer-checks, so adding it to
HOSTCFLAGS if HOSTCC is clang does not make sense.
It's not clear why the other warnings were disabled, and just for
HOSTCFLAGS, but I can remove them, add -Werror to HOSTCFLAGS and compile
with clang just fine.
Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
---
Makefile | 5 -----
1 file changed, 5 deletions(-)
diff --git a/Makefile b/Makefile
index cf007a31d575..5853d9492590 100644
--- a/Makefile
+++ b/Makefile
@@ -306,11 +306,6 @@ HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS)
HOSTLDFLAGS := $(HOST_LFS_LDFLAGS)
HOST_LOADLIBES := $(HOST_LFS_LIBS)
-ifeq ($(shell $(HOSTCC) -v 2>&1 | grep -c "clang version"), 1)
-HOSTCFLAGS += -Wno-unused-value -Wno-unused-parameter \
- -Wno-missing-field-initializers -fno-delete-null-pointer-checks
-endif
-
# Decide whether to build built-in, modular, or both.
# Normally, just do built-in.
--
2.11.0
next prev parent reply other threads:[~2017-10-07 20:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 2:28 [PATCH] kbuild: clang: remove crufty HOSTCFLAGS Nick Desaulniers
2017-09-28 10:52 ` Masahiro Yamada
2017-09-30 23:14 ` Nick Desaulniers
2017-10-01 0:38 ` Segher Boessenkool
2017-10-05 20:15 ` Masahiro Yamada
2017-10-07 20:23 ` Nick Desaulniers [this message]
2017-10-07 20:26 ` [PATCH v2] " Nick Desaulniers
2017-10-12 0:56 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171007202323.1993-1-nick.desaulniers@gmail.com \
--to=nick.desaulniers@gmail.com \
--cc=behanw@converseincode.com \
--cc=charlebm@gmail.com \
--cc=dl9pf@gmx.de \
--cc=ghackmann@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=md@google.com \
--cc=mka@chromium.org \
--cc=mmarek@suse.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).