[v2] kbuild: clang: remove crufty HOSTCFLAGS
diff mbox series

Message ID 20171007202323.1993-1-nick.desaulniers@gmail.com
State New, archived
Headers show
Series
  • [v2] kbuild: clang: remove crufty HOSTCFLAGS
Related show

Commit Message

Nick Desaulniers Oct. 7, 2017, 8:23 p.m. UTC
When compiling with `make CC=clang HOSTCC=clang`, I was seeing warnings
that clang did not recognize -fno-delete-null-pointer-checks for HOSTCC
targets.  These were added in commit 61163efae020 ("kbuild: LLVMLinux:
Add Kbuild support for building kernel with Clang").

Clang does not support -fno-delete-null-pointer-checks, so adding it to
HOSTCFLAGS if HOSTCC is clang does not make sense.

It's not clear why the other warnings were disabled, and just for
HOSTCFLAGS, but I can remove them, add -Werror to HOSTCFLAGS and compile
with clang just fine.

Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
---
 Makefile | 5 -----
 1 file changed, 5 deletions(-)

Comments

Nick Desaulniers Oct. 7, 2017, 8:26 p.m. UTC | #1
Sorry, I forgot to note the changes in v2:

* Dont add back -fno-delete-null-pointer-checks wrapped in
  hostcc-option, just remove all flags.
* Update wording of commit message.
Masahiro Yamada Oct. 12, 2017, 12:56 a.m. UTC | #2
2017-10-08 5:23 GMT+09:00 Nick Desaulniers <nick.desaulniers@gmail.com>:
> When compiling with `make CC=clang HOSTCC=clang`, I was seeing warnings
> that clang did not recognize -fno-delete-null-pointer-checks for HOSTCC
> targets.  These were added in commit 61163efae020 ("kbuild: LLVMLinux:
> Add Kbuild support for building kernel with Clang").
>
> Clang does not support -fno-delete-null-pointer-checks, so adding it to
> HOSTCFLAGS if HOSTCC is clang does not make sense.
>
> It's not clear why the other warnings were disabled, and just for
> HOSTCFLAGS, but I can remove them, add -Werror to HOSTCFLAGS and compile
> with clang just fine.
>
> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
> ---
>  Makefile | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index cf007a31d575..5853d9492590 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -306,11 +306,6 @@ HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS)
>  HOSTLDFLAGS  := $(HOST_LFS_LDFLAGS)
>  HOST_LOADLIBES := $(HOST_LFS_LIBS)
>
> -ifeq ($(shell $(HOSTCC) -v 2>&1 | grep -c "clang version"), 1)
> -HOSTCFLAGS  += -Wno-unused-value -Wno-unused-parameter \
> -               -Wno-missing-field-initializers -fno-delete-null-pointer-checks
> -endif

Applied to linux-kbuild/kbuild.  Thanks.

Patch
diff mbox series

diff --git a/Makefile b/Makefile
index cf007a31d575..5853d9492590 100644
--- a/Makefile
+++ b/Makefile
@@ -306,11 +306,6 @@  HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS)
 HOSTLDFLAGS  := $(HOST_LFS_LDFLAGS)
 HOST_LOADLIBES := $(HOST_LFS_LIBS)
 
-ifeq ($(shell $(HOSTCC) -v 2>&1 | grep -c "clang version"), 1)
-HOSTCFLAGS  += -Wno-unused-value -Wno-unused-parameter \
-		-Wno-missing-field-initializers -fno-delete-null-pointer-checks
-endif
-
 # Decide whether to build built-in, modular, or both.
 # Normally, just do built-in.