[v3,12/12] of: overlay: remove unneeded check for NULL kbasename()
diff mbox series

Message ID 1508283392-18252-13-git-send-email-frowand.list@gmail.com
State New, archived
Headers show
  • of: overlay: clean up device tree overlay code
Related show

Commit Message

Frank Rowand Oct. 17, 2017, 11:36 p.m. UTC
From: Frank Rowand <frank.rowand@sony.com>

kbasename() will not return NULL if passed a valid string.  If
the parameter passed to kbasename() in this case is already NULL
then the devicetree has been corrupted.

Signed-off-by: Frank Rowand <frank.rowand@sony.com>
 drivers/of/overlay.c | 2 --
 1 file changed, 2 deletions(-)

diff mbox series

diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index 0e9aefc1ff15..c99842bb4b09 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -331,8 +331,6 @@  static int add_changeset_node(struct overlay_changeset *ovcs,
 	int ret = 0;
 	node_kbasename = kbasename(node->full_name);
-	if (!node_kbasename)
-		return -ENOMEM;
 	for_each_child_of_node(target_node, tchild)
 		if (!of_node_cmp(node_kbasename, kbasename(tchild->full_name)))