linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stefan Brüns" <stefan.bruens@rwth-aachen.de>
To: <platform-driver-x86@vger.kernel.org>
Cc: linux-input@vger.kernel.org,
	"Stefan Brüns" <stefan.bruens@rwth-aachen.de>,
	"AceLan Kao" <acelan.kao@canonical.com>,
	"Andy Shevchenko" <andy@infradead.org>,
	"Darren Hart" <dvhart@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 5/5] platform/x86: intel-vbtn: support panel front button
Date: Thu, 9 Nov 2017 23:44:36 +0100	[thread overview]
Message-ID: <7c072721-1bd8-4921-b759-70bafb2ec894@rwthex-w2-a.rwth-ad.de> (raw)
In-Reply-To: <20171109224436.16472-1-stefan.bruens@rwth-aachen.de>

The Lenovo Helix 2 and Dell XPS 12 (9Q33) have an extra button on the
front showing a 'Windows' logo, both reporting event codes 0xC2/0xC3
on press/release. On the Dell, both press/release are distinct events
while on the Helix 2 both events are generated on release.

Tested on XPS 12, for info on the Helix 2 see:
https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html

Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>

---

Changes in v2:
- Emit KEY_LEFTMETA instead of KEY_MENU

 drivers/platform/x86/intel-vbtn.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
index a484bcc6393b..0861efe490d0 100644
--- a/drivers/platform/x86/intel-vbtn.c
+++ b/drivers/platform/x86/intel-vbtn.c
@@ -38,6 +38,8 @@ static const struct acpi_device_id intel_vbtn_ids[] = {
 static const struct key_entry intel_vbtn_keymap[] = {
 	{ KE_KEY, 0xC0, { KEY_POWER } },	/* power key press */
 	{ KE_IGNORE, 0xC1, { KEY_POWER } },	/* power key release */
+	{ KE_KEY, 0xC2, { KEY_LEFTMETA } },		/* 'Windows' key press */
+	{ KE_KEY, 0xC3, { KEY_LEFTMETA } },		/* 'Windows' key release */
 	{ KE_KEY, 0xC4, { KEY_VOLUMEUP } },		/* volume-up key press */
 	{ KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },		/* volume-up key release */
 	{ KE_KEY, 0xC6, { KEY_VOLUMEDOWN } },		/* volume-down key press */
-- 
2.15.0

  parent reply	other threads:[~2017-11-09 22:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20171109224436.16472-1-stefan.bruens@rwth-aachen.de>
2017-11-09 22:44 ` [PATCH v2 1/5] platform/x86: intel-vbtn: support SW_TABLET_MODE Stefan Brüns
2017-11-09 22:44 ` [PATCH v2 2/5] platform/x86: intel-vbtn: Support separate press/release events Stefan Brüns
2017-11-10  1:34   ` Darren Hart
2017-11-10  1:58     ` Stefan Brüns
2017-11-10  2:11       ` Darren Hart
2017-11-10  2:44         ` Stefan Brüns
2017-11-10  2:15   ` Darren Hart
2017-12-08 20:33     ` Stefan Brüns
2017-11-09 22:44 ` [PATCH v2 3/5] Input: add KEY_ROTATE_LOCK_TOGGLE Stefan Brüns
2017-11-09 23:34   ` Bastien Nocera
2017-11-30 17:51     ` Brüns, Stefan
2017-12-05 18:50       ` Jason Gerecke
2018-01-25 16:23         ` Jason Gerecke
2017-11-10  1:41   ` Darren Hart
2017-11-09 22:44 ` [PATCH v2 4/5] platform/x86: intel-vbtn: support KEY_ROTATE_LOCK_TOGGLE Stefan Brüns
2017-11-09 23:30   ` Bastien Nocera
2017-11-09 23:46     ` Darren Hart
2017-11-10  0:23       ` Stefan Brüns
2017-11-10  0:15     ` Stefan Brüns
2017-11-10  0:39       ` Bastien Nocera
2017-11-10  0:53       ` Darren Hart
2017-11-10  1:54       ` Darren Hart
2017-11-10  2:20         ` Stefan Brüns
2017-11-09 22:44 ` Stefan Brüns [this message]
2017-11-09 23:40   ` [PATCH v2 5/5] platform/x86: intel-vbtn: support panel front button Bastien Nocera
2017-11-10  0:21     ` Stefan Brüns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c072721-1bd8-4921-b759-70bafb2ec894@rwthex-w2-a.rwth-ad.de \
    --to=stefan.bruens@rwth-aachen.de \
    --cc=acelan.kao@canonical.com \
    --cc=andy@infradead.org \
    --cc=dvhart@infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).