IB: INFINIBAND should depend on HAS_DMA
diff mbox series

Message ID 1511117910-25003-1-git-send-email-geert@linux-m68k.org
State New, archived
Headers show
Series
  • IB: INFINIBAND should depend on HAS_DMA
Related show

Commit Message

Geert Uytterhoeven Nov. 19, 2017, 6:58 p.m. UTC
If NO_DMA=y:

    ERROR: "bad_dma_ops" [net/sunrpc/xprtrdma/rpcrdma.ko] undefined!
    ERROR: "bad_dma_ops" [net/smc/smc.ko] undefined!
    ERROR: "bad_dma_ops" [net/rds/rds_rdma.ko] undefined!
    ERROR: "bad_dma_ops" [net/9p/9pnet_rdma.ko] undefined!
    ERROR: "bad_dma_ops" [drivers/nvme/target/nvmet-rdma.ko] undefined!
    ERROR: "bad_dma_ops" [drivers/nvme/host/nvme-rdma.ko] undefined!
    ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined!
    ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srp/ib_srp.ko] undefined!
    ERROR: "bad_dma_ops" [drivers/infiniband/ulp/isert/ib_isert.ko] undefined!
    ERROR: "bad_dma_ops" [drivers/infiniband/ulp/iser/ib_iser.ko] undefined!
    ERROR: "bad_dma_ops" [drivers/infiniband/ulp/ipoib/ib_ipoib.ko] undefined!
    ERROR: "bad_dma_ops" [drivers/infiniband/core/ib_core.ko] undefined!

Before, this was handled implicitly by the dependency on PCI.
Add an explicit dependency on HAS_DMA to fix this.

Fixes: 931bc0d91639f8fb ("IB: Move PCI dependency from root KConfig to HW's KConfigs")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/infiniband/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Leon Romanovsky Nov. 21, 2017, 6:06 a.m. UTC | #1
On Sun, Nov 19, 2017 at 07:58:30PM +0100, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
>     ERROR: "bad_dma_ops" [net/sunrpc/xprtrdma/rpcrdma.ko] undefined!
>     ERROR: "bad_dma_ops" [net/smc/smc.ko] undefined!
>     ERROR: "bad_dma_ops" [net/rds/rds_rdma.ko] undefined!
>     ERROR: "bad_dma_ops" [net/9p/9pnet_rdma.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/nvme/target/nvmet-rdma.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/nvme/host/nvme-rdma.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srp/ib_srp.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/ulp/isert/ib_isert.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/ulp/iser/ib_iser.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/ulp/ipoib/ib_ipoib.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/core/ib_core.ko] undefined!
>
> Before, this was handled implicitly by the dependency on PCI.
> Add an explicit dependency on HAS_DMA to fix this.
>
> Fixes: 931bc0d91639f8fb ("IB: Move PCI dependency from root KConfig to HW's KConfigs")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  drivers/infiniband/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Jason Gunthorpe Dec. 2, 2017, 12:01 a.m. UTC | #2
On Sun, Nov 19, 2017 at 07:58:30PM +0100, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
>     ERROR: "bad_dma_ops" [net/sunrpc/xprtrdma/rpcrdma.ko] undefined!
>     ERROR: "bad_dma_ops" [net/smc/smc.ko] undefined!
>     ERROR: "bad_dma_ops" [net/rds/rds_rdma.ko] undefined!
>     ERROR: "bad_dma_ops" [net/9p/9pnet_rdma.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/nvme/target/nvmet-rdma.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/nvme/host/nvme-rdma.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srp/ib_srp.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/ulp/isert/ib_isert.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/ulp/iser/ib_iser.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/ulp/ipoib/ib_ipoib.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/core/ib_core.ko] undefined!
> 
> Before, this was handled implicitly by the dependency on PCI.
> Add an explicit dependency on HAS_DMA to fix this.
> 
> Fixes: 931bc0d91639f8fb ("IB: Move PCI dependency from root KConfig to HW's KConfigs")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
>  drivers/infiniband/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-rc, thanks

Jason

Patch
diff mbox series

diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
index 98ac46ed7214f574..cbf186522016f97f 100644
--- a/drivers/infiniband/Kconfig
+++ b/drivers/infiniband/Kconfig
@@ -1,6 +1,6 @@ 
 menuconfig INFINIBAND
 	tristate "InfiniBand support"
-	depends on HAS_IOMEM
+	depends on HAS_IOMEM && HAS_DMA
 	depends on NET
 	depends on INET
 	depends on m || IPV6 != m