[2/2] serial: sccnxp: Improve a size determination in sccnxp_probe()
diff mbox series

Message ID e52a355c-1b56-dd0e-89e4-d489df5d96dc@users.sourceforge.net
State New, archived
Headers show
  • tty/serial/sccnxp: Adjustments for sccnxp_probe()
Related show

Commit Message

SF Markus Elfring Dec. 7, 2017, 9:20 p.m. UTC
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 7 Dec 2017 22:00:40 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
 drivers/tty/serial/sccnxp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

diff --git a/drivers/tty/serial/sccnxp.c b/drivers/tty/serial/sccnxp.c
index ba1653ba5f37..21be1fb5fd6d 100644
--- a/drivers/tty/serial/sccnxp.c
+++ b/drivers/tty/serial/sccnxp.c
@@ -856,7 +856,7 @@  static int sccnxp_probe(struct platform_device *pdev)
 	if (IS_ERR(membase))
 		return PTR_ERR(membase);
-	s = devm_kzalloc(&pdev->dev, sizeof(struct sccnxp_port), GFP_KERNEL);
+	s = devm_kzalloc(&pdev->dev, sizeof(*s), GFP_KERNEL);
 	if (!s)
 		return -ENOMEM;