From: Suren Baghdasaryan <surenb@google.com>
To: akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org,
hillf.zj@alibaba-inc.com, minchan@kernel.org,
mgorman@techsingularity.net, ying.huang@intel.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: timmurray@google.com, tkjos@google.com,
Suren Baghdasaryan <surenb@google.com>
Subject: [PATCH v2] mm: terminate shrink_slab loop if signal is pending
Date: Thu, 7 Dec 2017 17:23:05 -0800 [thread overview]
Message-ID: <20171208012305.83134-1-surenb@google.com> (raw)
Slab shrinkers can be quite time consuming and when signal
is pending they can delay handling of the signal. If fatal
signal is pending there is no point in shrinking that process
since it will be killed anyway. This change checks for pending
fatal signals inside shrink_slab loop and if one is detected
terminates this loop early.
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
---
V2:
Sergey Senozhatsky:
- Fix missing parentheses
---
mm/vmscan.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index c02c850ea349..28e4bdc72c16 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -486,6 +486,13 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,
.memcg = memcg,
};
+ /*
+ * We are about to die and free our memory.
+ * Stop shrinking which might delay signal handling.
+ */
+ if (unlikely(fatal_signal_pending(current)))
+ break;
+
/*
* If kernel memory accounting is disabled, we ignore
* SHRINKER_MEMCG_AWARE flag and call all shrinkers
--
2.15.1.424.g9478a66081-goog
next reply other threads:[~2017-12-08 1:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 1:23 Suren Baghdasaryan [this message]
2017-12-08 8:22 ` [PATCH v2] mm: terminate shrink_slab loop if signal is pending Michal Hocko
2017-12-08 11:36 ` Tetsuo Handa
2017-12-08 11:48 ` Michal Hocko
2017-12-08 14:03 ` Tetsuo Handa
2017-12-08 18:06 ` Suren Baghdasaryan
2017-12-09 8:08 ` Tetsuo Handa
2017-12-10 10:17 ` Michal Hocko
2017-12-11 21:05 ` Suren Baghdasaryan
2017-12-10 10:13 ` Michal Hocko
2017-12-10 11:37 ` Tetsuo Handa
2017-12-11 21:12 ` Suren Baghdasaryan
2017-12-08 21:02 ` David Rientjes
2017-12-09 3:16 ` Suren Baghdasaryan
2017-12-09 12:44 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208012305.83134-1-surenb@google.com \
--to=surenb@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=timmurray@google.com \
--cc=tkjos@google.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).