linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Al Viro <viro@ZenIV.linux.org.uk>
Subject: sched: Update kerneldoc for sched_rr_get_interval()
Date: Mon, 11 Dec 2017 15:56:51 -0700	[thread overview]
Message-ID: <20171211155651.7b098034@lwn.net> (raw)

Commit abca5fc535a3e ("sched_rr_get_interval(): move compat to native, get
rid of set_fs()") changed the prototype of that function but left the
kerneldoc comments unchanged, leading to these docs-build warnings:

  ./kernel/sched/core.c:5113: warning: No description found for parameter 't'
  ./kernel/sched/core.c:5113: warning: Excess function parameter 'interval'
  			      description in 'sched_rr_get_interval'

Update the documentation (noting that it's not a user-space address
anymore) and make the docs build a little quieter.

Signed-off-by: Jonathan Corbet <corbet@lwn.net>
---
 kernel/sched/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 75554f366fd3..a6e9edb55333 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5100,12 +5100,12 @@ SYSCALL_DEFINE1(sched_get_priority_min, int, policy)
 /**
  * sys_sched_rr_get_interval - return the default timeslice of a process.
  * @pid: pid of the process.
- * @interval: userspace pointer to the timeslice value.
+ * @t: pointer to the timeslice value.
  *
  * this syscall writes the default timeslice value of a given process
- * into the user-space timespec buffer. A value of '0' means infinity.
+ * into the timespec64 buffer. A value of '0' means infinity.
  *
- * Return: On success, 0 and the timeslice is in @interval. Otherwise,
+ * Return: On success, 0 and the timeslice is in @t. Otherwise,
  * an error code.
  */
 static int sched_rr_get_interval(pid_t pid, struct timespec64 *t)
-- 
2.14.3

             reply	other threads:[~2017-12-11 22:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-11 22:56 Jonathan Corbet [this message]
2017-12-11 23:14 ` sched: Update kerneldoc for sched_rr_get_interval() Randy Dunlap
2017-12-11 23:25   ` Jonathan Corbet
2017-12-12 10:18     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171211155651.7b098034@lwn.net \
    --to=corbet@lwn.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).