linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Desaulniers <ndesaulniers@google.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: tj@kernel.org, cl@linux.com, mingo@redhat.com, hpa@zytor.com,
	bp@suse.de, luto@kernel.org, kirill.shutemov@linux.intel.com,
	thgarnie@google.com, jpoimboe@redhat.com, minipli@googlemail.com,
	me@kylehuey.com, namit@vmware.com, tklauser@distanz.ch,
	thomas.lendacky@amd.com, linux-kernel@vger.kernel.org,
	x86@kernel.org, Nick Desaulniers <ndesaulniers@google.com>,
	Borislav Petkov <bpetkov@suse.de>
Subject: [PATCH] x86/process: define cpu_tss_rw in same section as declaration
Date: Wed,  3 Jan 2018 12:39:52 -0800	[thread overview]
Message-ID: <20180103203954.183360-1-ndesaulniers@google.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1801032025310.1957@nanos>

cpu_tss_rw was declared with the macro

DECLARE_PER_CPU_PAGE_ALIGNED

but then defined with the macro

DEFINE_PER_CPU_SHARED_ALIGNED

leading to section mismatch warnings. Prefer the macro

DEFINE_PER_CPU_PAGE_ALIGNED

Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
 arch/x86/kernel/process.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index aed9d94bd46f..832a6acd730f 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -47,7 +47,7 @@
  * section. Since TSS's are completely CPU-local, we want them
  * on exact cacheline boundaries, to eliminate cacheline ping-pong.
  */
-__visible DEFINE_PER_CPU_SHARED_ALIGNED(struct tss_struct, cpu_tss_rw) = {
+__visible DEFINE_PER_CPU_PAGE_ALIGNED(struct tss_struct, cpu_tss_rw) = {
 	.x86_tss = {
 		/*
 		 * .sp0 is only used when entering ring 0 from a lower
-- 
2.16.0.rc0.223.g4a4ac83678-goog

  reply	other threads:[~2018-01-03 20:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-02 18:51 correct section for cpu_tss_rw? Nick Desaulniers
2018-01-03 19:27 ` Thomas Gleixner
2018-01-03 20:39   ` Nick Desaulniers [this message]
2018-01-03 22:25     ` [tip:x86/pti] x86/process: Define cpu_tss_rw in same section as declaration tip-bot for Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180103203954.183360-1-ndesaulniers@google.com \
    --to=ndesaulniers@google.com \
    --cc=bp@suse.de \
    --cc=bpetkov@suse.de \
    --cc=cl@linux.com \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@redhat.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=me@kylehuey.com \
    --cc=mingo@redhat.com \
    --cc=minipli@googlemail.com \
    --cc=namit@vmware.com \
    --cc=tglx@linutronix.de \
    --cc=thgarnie@google.com \
    --cc=thomas.lendacky@amd.com \
    --cc=tj@kernel.org \
    --cc=tklauser@distanz.ch \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).