From: Boqun Feng <boqun.feng@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Boqun Feng <boqun.feng@gmail.com>
Subject: [RFC tip/locking/lockdep v4 04/17] lockdep: Introduce lock_list::dep
Date: Tue, 9 Jan 2018 22:38:47 +0800 [thread overview]
Message-ID: <20180109143900.27475-5-boqun.feng@gmail.com> (raw)
In-Reply-To: <20180109143900.27475-1-boqun.feng@gmail.com>
To add recursive read locks into the dependency graph, we need to store
the types of dependencies for the BFS later. There are four kinds of
dependencies:
* Non-recursive -> Non-recursive dependencies(NN)
e.g. write_lock(prev) -> write_lock(next), we can also write
this as "prev --(NN)--> next".
* Recursive -> Non-recursive dependencies(RN)
e.g. read_lock(prev) -> write_lock(next), we can also write this
as "prev --(RN)--> next".
* Non-recursive -> recursive dependencies(NR)
e.g. write_lock(prev) -> read_lock(next), we can also write this
as "prev --(NR)--> next".
* Recursive -> recursive dependencies(RR)
e.g. read_lock(prev) -> read_lock(next), we can also write this
as "prev --(RR)--> next".
Given a pair of two locks, four kinds of dependencies could all exist
between them, so we use 4 bit for the presence of each kind(stored in
lock_list::dep). Helper functions and marcos are also introduced to
convert a pair of locks into ::dep bit and maintain the addition of
different kinds of dependencies.
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
---
include/linux/lockdep.h | 2 ++
kernel/locking/lockdep.c | 48 +++++++++++++++++++++++++++++++++++++++++++++---
2 files changed, 47 insertions(+), 3 deletions(-)
diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h
index 2e75dc34bff5..d122e45a30ea 100644
--- a/include/linux/lockdep.h
+++ b/include/linux/lockdep.h
@@ -187,6 +187,8 @@ struct lock_list {
struct lock_class *class;
struct stack_trace trace;
int distance;
+ /* bitmap of different dependencies from head to this */
+ u16 dep;
/*
* The parent field is used to implement breadth-first search, and the
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 8767830664aa..136448d5a5bc 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -854,7 +854,7 @@ static struct lock_list *alloc_list_entry(void)
* Add a new dependency to the head of the list:
*/
static int add_lock_to_list(struct lock_class *this, struct list_head *head,
- unsigned long ip, int distance,
+ unsigned long ip, int distance, unsigned int dep,
struct stack_trace *trace)
{
struct lock_list *entry;
@@ -867,6 +867,7 @@ static int add_lock_to_list(struct lock_class *this, struct list_head *head,
return 0;
entry->class = this;
+ entry->dep = dep;
entry->distance = distance;
entry->trace = *trace;
/*
@@ -1007,6 +1008,33 @@ static inline bool bfs_error(enum bfs_result res)
return res < 0;
}
+#define DEP_NN_BIT 0
+#define DEP_RN_BIT 1
+#define DEP_NR_BIT 2
+#define DEP_RR_BIT 3
+
+#define DEP_NN_MASK (1U << (DEP_NN_BIT))
+#define DEP_RN_MASK (1U << (DEP_RN_BIT))
+#define DEP_NR_MASK (1U << (DEP_NR_BIT))
+#define DEP_RR_MASK (1U << (DEP_RR_BIT))
+
+static inline unsigned int __calc_dep_bit(int prev, int next)
+{
+ if (prev == 2 && next != 2)
+ return DEP_RN_BIT;
+ if (prev != 2 && next == 2)
+ return DEP_NR_BIT;
+ if (prev == 2 && next == 2)
+ return DEP_RR_BIT;
+ else
+ return DEP_NN_BIT;
+}
+
+static inline unsigned int calc_dep(int prev, int next)
+{
+ return 1U << __calc_dep_bit(prev, next);
+}
+
static enum bfs_result __bfs(struct lock_list *source_entry,
void *data,
int (*match)(struct lock_list *entry, void *data),
@@ -1916,6 +1944,16 @@ check_prev_add(struct task_struct *curr, struct held_lock *prev,
if (entry->class == hlock_class(next)) {
if (distance == 1)
entry->distance = 1;
+ entry->dep |= calc_dep(prev->read, next->read);
+ }
+ }
+
+ /* Also, update the reverse dependency in @next's ->locks_before list */
+ list_for_each_entry(entry, &hlock_class(next)->locks_before, entry) {
+ if (entry->class == hlock_class(prev)) {
+ if (distance == 1)
+ entry->distance = 1;
+ entry->dep |= calc_dep(next->read, prev->read);
return 1;
}
}
@@ -1943,14 +1981,18 @@ check_prev_add(struct task_struct *curr, struct held_lock *prev,
*/
ret = add_lock_to_list(hlock_class(next),
&hlock_class(prev)->locks_after,
- next->acquire_ip, distance, trace);
+ next->acquire_ip, distance,
+ calc_dep(prev->read, next->read),
+ trace);
if (!ret)
return 0;
ret = add_lock_to_list(hlock_class(prev),
&hlock_class(next)->locks_before,
- next->acquire_ip, distance, trace);
+ next->acquire_ip, distance,
+ calc_dep(next->read, prev->read),
+ trace);
if (!ret)
return 0;
--
2.15.1
next prev parent reply other threads:[~2018-01-09 14:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 14:38 [RFC tip/locking/lockdep v4 00/17] lockdep: Support deadlock detection for recursive read locks Boqun Feng
2018-01-09 14:38 ` [RFC tip/locking/lockdep v4 01/17] lockdep: Demagic the return value of BFS Boqun Feng
2018-01-09 14:38 ` [RFC tip/locking/lockdep v4 02/17] lockdep: Make __bfs() visit every dependency until a match Boqun Feng
2018-01-09 14:38 ` [RFC tip/locking/lockdep v4 03/17] lockdep: Redefine LOCK_*_STATE* bits Boqun Feng
2018-01-09 14:38 ` Boqun Feng [this message]
2018-01-09 14:38 ` [RFC tip/locking/lockdep v4 05/17] lockdep: Extend __bfs() to work with multiple kinds of dependencies Boqun Feng
2018-01-09 14:38 ` [RFC tip/locking/lockdep v4 06/17] lockdep: Support deadlock detection for recursive read in check_noncircular() Boqun Feng
2018-01-09 14:38 ` [RFC tip/locking/lockdep v4 07/17] lockdep: Adjust check_redundant() for recursive read change Boqun Feng
2018-01-09 14:38 ` [RFC tip/locking/lockdep v4 08/17] lockdep: Fix recursive read lock related safe->unsafe detection Boqun Feng
2018-01-09 14:38 ` [RFC tip/locking/lockdep v4 09/17] lockdep: Add recursive read locks into dependency graph Boqun Feng
2018-01-09 14:38 ` [RFC tip/locking/lockdep v4 10/17] lockdep/selftest: Add a R-L/L-W test case specific to chain cache behavior Boqun Feng
2018-01-09 14:38 ` [RFC tip/locking/lockdep v4 11/17] lockdep: Take read/write status in consideration when generate chainkey Boqun Feng
2018-01-09 14:38 ` [RFC tip/locking/lockdep v4 12/17] lockdep/selftest: Unleash irq_read_recursion2 and add more Boqun Feng
2018-01-09 14:38 ` [RFC tip/locking/lockdep v4 13/17] lockdep/selftest: Add more recursive read related test cases Boqun Feng
2018-01-09 14:38 ` [RFC tip/locking/lockdep v4 14/17] Revert "locking/lockdep/selftests: Fix mixed read-write ABBA tests" Boqun Feng
2018-01-09 14:38 ` [RFC tip/locking/lockdep v4 15/17] lockdep: Reduce the size of lock_list Boqun Feng
2018-01-09 14:38 ` [RFC tip/locking/lockdep v4 16/17] lockdep: Documention for recursive read lock detection reasoning Boqun Feng
2018-01-25 1:05 ` Randy Dunlap
2018-01-25 1:40 ` Boqun Feng
2018-01-09 14:39 ` [RFC tip/locking/lockdep v4 17/17] MAINTAINERS: Add myself as a LOCKING PRIMITIVES reviewer Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109143900.27475-5-boqun.feng@gmail.com \
--to=boqun.feng@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).