From: Thierry Escande <thierry.escande@collabora.com>
To: Rob Herring <robh+dt@kernel.org>,
Archit Taneja <architt@codeaurora.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sandy Huang <hjc@rock-chips.com>
Cc: Jeffy Chen <jeffy.chen@rock-chips.com>,
Sean Paul <seanpaul@chromium.org>,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v7 3/8] drm/rockchip: analogix_dp: Add a sanity check for rockchip_drm_psr_register()
Date: Tue, 9 Jan 2018 15:48:48 +0100 [thread overview]
Message-ID: <20180109144853.32536-4-thierry.escande@collabora.com> (raw)
In-Reply-To: <20180109144853.32536-1-thierry.escande@collabora.com>
From: Jeffy Chen <jeffy.chen@rock-chips.com>
The rockchip_drm_psr_register() can fail, so add a sanity check for that.
Also reorder the calls in unbind() to match bind().
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
---
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
index 37250ab63bd7..eb88c52336a7 100644
--- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
@@ -354,15 +354,22 @@ static int rockchip_dp_bind(struct device *dev, struct device *master,
dp->psr_state = ~EDP_VSC_PSR_STATE_ACTIVE;
INIT_WORK(&dp->psr_work, analogix_dp_psr_work);
- rockchip_drm_psr_register(&dp->encoder, analogix_dp_psr_set);
+ ret = rockchip_drm_psr_register(&dp->encoder, analogix_dp_psr_set);
+ if (ret < 0)
+ goto err_cleanup_encoder;
dp->adp = analogix_dp_bind(dev, dp->drm_dev, &dp->plat_data);
if (IS_ERR(dp->adp)) {
- dp->encoder.funcs->destroy(&dp->encoder);
- return PTR_ERR(dp->adp);
+ ret = PTR_ERR(dp->adp);
+ goto err_unreg_psr;
}
return 0;
+err_unreg_psr:
+ rockchip_drm_psr_unregister(&dp->encoder);
+err_cleanup_encoder:
+ dp->encoder.funcs->destroy(&dp->encoder);
+ return ret;
}
static void rockchip_dp_unbind(struct device *dev, struct device *master,
@@ -370,8 +377,8 @@ static void rockchip_dp_unbind(struct device *dev, struct device *master,
{
struct rockchip_dp_device *dp = dev_get_drvdata(dev);
- rockchip_drm_psr_unregister(&dp->encoder);
analogix_dp_unbind(dp->adp);
+ rockchip_drm_psr_unregister(&dp->encoder);
dp->encoder.funcs->destroy(&dp->encoder);
}
--
2.14.1
next prev parent reply other threads:[~2018-01-09 14:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 14:48 [PATCH v7 00/10] rockchip: kevin: Enable edp display Thierry Escande
2018-01-09 14:48 ` [PATCH v7 1/8] drm/bridge: analogix: Do not use device's drvdata Thierry Escande
2018-01-09 14:48 ` [PATCH v7 2/8] drm/bridge: analogix_dp: Fix connector and encoder cleanup Thierry Escande
2018-01-09 14:48 ` Thierry Escande [this message]
2018-01-09 14:48 ` [PATCH v7 4/8] drm/rockchip: dw-mipi-dsi: Fix error handling path Thierry Escande
2018-01-10 9:58 ` Archit Taneja
2018-01-09 14:48 ` [PATCH v7 5/8] drm/rockchip: inno_hdmi: " Thierry Escande
2018-01-09 14:48 ` [PATCH v7 6/8] drm/bridge/synopsys: dw-hdmi: Add missing bridge detach Thierry Escande
2018-01-10 9:14 ` Archit Taneja
2018-01-09 14:48 ` [PATCH v7 7/8] drm/bridge/synopsys: dw-hdmi: Do not use device's drvdata Thierry Escande
2018-01-10 9:33 ` Archit Taneja
2018-01-09 14:48 ` [PATCH v7 8/8] drm/rockchip: dw_hdmi: Fix error handling path Thierry Escande
2018-01-10 9:46 ` [PATCH v7 00/10] rockchip: kevin: Enable edp display Archit Taneja
2018-01-24 7:38 ` JeffyChen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109144853.32536-4-thierry.escande@collabora.com \
--to=thierry.escande@collabora.com \
--cc=architt@codeaurora.org \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=jeffy.chen@rock-chips.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).