From: Faiz Abbas <faiz_abbas@ti.com>
To: <wg@grandegger.com>, <mkl@pengutronix.de>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>
Cc: <linux-can@vger.kernel.org>, <netdev@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<faiz_abbas@ti.com>, <nsekhar@ti.com>, <fcooper@ti.com>,
<robh@kernel.org>, <Wenyou.Yang@microchip.com>,
<sergei.shtylyov@cogentembedded.com>,
<linux-omap@vger.kernel.org>, <b29396@freescale.com>
Subject: [PATCH v7 4/8] can: m_can: Move allocation of net device to probe
Date: Wed, 10 Jan 2018 16:25:21 +0530 [thread overview]
Message-ID: <1515581725-29242-5-git-send-email-faiz_abbas@ti.com> (raw)
In-Reply-To: <1515581725-29242-1-git-send-email-faiz_abbas@ti.com>
With the version no longer required to allocate the net device, it can
be moved to probe and the alloc_m_can_dev() function can be simplified.
Therefore, move the allocation of net device to probe and change
alloc_m_can_dev() to setup_m_can_dev().
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
drivers/net/can/m_can/m_can.c | 28 +++++++++++++---------------
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 893edbb..07ebe7f 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -1207,25 +1207,20 @@ static bool m_can_niso_supported(const struct m_can_priv *priv)
return !niso_timeout;
}
-static struct net_device *alloc_m_can_dev(struct platform_device *pdev,
- void __iomem *addr, u32 tx_fifo_size)
+static int setup_m_can_dev(struct platform_device *pdev, struct net_device *dev,
+ void __iomem *addr)
{
- struct net_device *dev;
struct m_can_priv *priv;
int m_can_version;
m_can_version = m_can_check_core_release(addr);
/* return if unsupported version */
if (!m_can_version) {
- dev = NULL;
- goto return_dev;
+ dev_err(&pdev->dev, "Unsupported version number: %2d",
+ m_can_version);
+ return -EINVAL;
}
- dev = alloc_candev(sizeof(*priv), tx_fifo_size);
- if (!dev) {
- dev = NULL;
- goto return_dev;
- }
priv = netdev_priv(dev);
netif_napi_add(dev, &priv->napi, m_can_poll, M_CAN_NAPI_WEIGHT);
@@ -1271,12 +1266,10 @@ static struct net_device *alloc_m_can_dev(struct platform_device *pdev,
free_m_can_dev(dev);
dev_err(&pdev->dev, "Unsupported version number: %2d",
priv->version);
- dev = NULL;
- break;
+ return -EINVAL;
}
-return_dev:
- return dev;
+ return 0;
}
static int m_can_open(struct net_device *dev)
@@ -1616,11 +1609,16 @@ static int m_can_plat_probe(struct platform_device *pdev)
tx_fifo_size = mram_config_vals[7];
/* allocate the m_can device */
- dev = alloc_m_can_dev(pdev, addr, tx_fifo_size);
+ dev = alloc_candev(sizeof(*priv), tx_fifo_size);
if (!dev) {
ret = -ENOMEM;
goto disable_cclk_ret;
}
+
+ ret = setup_m_can_dev(pdev, dev, addr);
+ if (ret)
+ goto disable_cclk_ret;
+
priv = netdev_priv(dev);
dev->irq = irq;
priv->device = &pdev->dev;
--
2.7.4
next prev parent reply other threads:[~2018-01-10 10:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 10:55 [PATCH v7 0/8] Add MCAN Support for Dra76 platform Faiz Abbas
2018-01-10 10:55 ` [PATCH v7 1/8] can: dev: Add support for limiting configured bitrate Faiz Abbas
2018-01-15 13:40 ` Marc Kleine-Budde
2018-01-10 10:55 ` [PATCH v7 2/8] can: m_can: Add call to of_can_transceiver Faiz Abbas
2018-01-10 10:55 ` [PATCH v7 3/8] can: m_can: Remove check for version when allocating m_can net device Faiz Abbas
2018-01-10 10:55 ` Faiz Abbas [this message]
2018-01-15 13:52 ` [PATCH v7 4/8] can: m_can: Move allocation of net device to probe Marc Kleine-Budde
2018-01-16 9:03 ` Faiz Abbas
2018-01-10 10:55 ` [PATCH v7 5/8] can: m_can: Add PM Support Faiz Abbas
2018-01-15 13:55 ` Marc Kleine-Budde
2018-01-16 11:05 ` Faiz Abbas
2018-01-10 10:55 ` [PATCH v7 6/8] can: m_can: Support higher speed CAN-FD bitrates Faiz Abbas
2018-01-10 10:55 ` [PATCH v7 7/8] dt-bindings: can: m_can: Document new can transceiver binding Faiz Abbas
2018-01-11 20:20 ` Rob Herring
2018-01-12 6:24 ` Faiz Abbas
2018-01-10 10:55 ` [PATCH v7 8/8] dt-bindings: can: can-transceiver: Document new binding Faiz Abbas
2018-01-15 14:44 ` [PATCH v7 0/8] Add MCAN Support for Dra76 platform Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515581725-29242-5-git-send-email-faiz_abbas@ti.com \
--to=faiz_abbas@ti.com \
--cc=Wenyou.Yang@microchip.com \
--cc=b29396@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=fcooper@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).