From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: bhelgaas@google.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] x86/PCI: limit the size of the 64bit window to 256GB v2
Date: Wed, 10 Jan 2018 13:25:51 +0100 [thread overview]
Message-ID: <20180110122551.1637-2-christian.koenig@amd.com> (raw)
In-Reply-To: <20180110122551.1637-1-christian.koenig@amd.com>
Avoid problems with BIOS implementations which don't report all used
resources to the OS by only allocating a 256GB window directly below the
hardware limit.
v2: cleanup code a bit more, update comment and explain the hw limit
Signed-off-by: Christian König <christian.koenig@amd.com>
---
arch/x86/pci/fixup.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c
index a91280da2ea1..9c1c98d7e3a7 100644
--- a/arch/x86/pci/fixup.c
+++ b/arch/x86/pci/fixup.c
@@ -662,10 +662,11 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x2033, quirk_no_aersid);
*/
static void pci_amd_enable_64bit_bar(struct pci_dev *dev)
{
- unsigned i;
u32 base, limit, high;
- struct resource *res, *conflict;
struct pci_dev *other;
+ struct resource *res;
+ unsigned i;
+ int r;
if (!(pci_probe & PCI_BIG_ROOT_WINDOW))
return;
@@ -702,19 +703,17 @@ static void pci_amd_enable_64bit_bar(struct pci_dev *dev)
if (!res)
return;
+ /* Allocate a 256GB window directly below the 0xfd00000000 hw limit */
res->name = "PCI Bus 0000:00";
res->flags = IORESOURCE_PREFETCH | IORESOURCE_MEM |
IORESOURCE_MEM_64 | IORESOURCE_WINDOW;
- res->start = 0x100000000ull;
+ res->start = 0xbd00000000ull;
res->end = 0xfd00000000ull - 1;
- /* Just grab the free area behind system memory for this */
- while ((conflict = request_resource_conflict(&iomem_resource, res))) {
- if (conflict->end >= res->end) {
- kfree(res);
- return;
- }
- res->start = conflict->end + 1;
+ r = request_resource(&iomem_resource, res);
+ if (r) {
+ kfree(res);
+ return;
}
dev_info(&dev->dev, "adding root bus resource %pR\n", res);
--
2.11.0
next prev parent reply other threads:[~2018-01-10 12:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 12:25 [PATCH 1/2] x86/PCI: add kernel option and taint it when we add a 64bit window Christian König
2018-01-10 12:25 ` Christian König [this message]
2018-01-10 18:02 ` [PATCH 2/2] x86/PCI: limit the size of the 64bit window to 256GB v2 Bjorn Helgaas
2018-01-10 18:14 ` Christian König
2018-01-10 20:37 ` Bjorn Helgaas
2018-01-10 20:10 ` [PATCH 1/2] x86/PCI: add kernel option and taint it when we add a 64bit window Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110122551.1637-2-christian.koenig@amd.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).