From: "Vladislav Valtchev (VMware)" <vladislav.valtchev@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
y.karadz@gmail.com,
"Vladislav Valtchev (VMware)" <vladislav.valtchev@gmail.com>
Subject: [PATCH v3 3/3] trace-cmd: Making stat to report when the stack tracer is ON
Date: Tue, 16 Jan 2018 09:47:44 +0200 [thread overview]
Message-ID: <20180116074744.5522-4-vladislav.valtchev@gmail.com> (raw)
In-Reply-To: <20180116074744.5522-1-vladislav.valtchev@gmail.com>
trace-cmd stat is a handy way for users to see what tracing is currently going
on, but currently it does not say anything about the stack tracing. This patch
makes the command to show a message when the stack tracer is ON.
Signed-off-by: Vladislav Valtchev (VMware) <vladislav.valtchev@gmail.com>
---
trace-cmd.h | 2 ++
trace-stack.c | 6 ++++++
trace-stat.c | 8 ++++++++
3 files changed, 16 insertions(+)
diff --git a/trace-cmd.h b/trace-cmd.h
index 6fd34d7..9704b2e 100644
--- a/trace-cmd.h
+++ b/trace-cmd.h
@@ -358,6 +358,8 @@ void tracecmd_free_hooks(struct hook_list *hooks);
/* --- Hack! --- */
int tracecmd_blk_hack(struct tracecmd_input *handle);
+/* --- Stack tracer functions --- */
+int tracecmd_stack_tracer_status(int *status);
/* --- Debugging --- */
struct kbuffer *tracecmd_record_kbuf(struct tracecmd_input *handle,
diff --git a/trace-stack.c b/trace-stack.c
index d55d994..0028ecc 100644
--- a/trace-stack.c
+++ b/trace-stack.c
@@ -107,6 +107,12 @@ static int read_proc(int *status)
return 1; /* full success */
}
+/* Public wrapper of read_proc() */
+int tracecmd_stack_tracer_status(int *status)
+{
+ return read_proc(status);
+}
+
/* NOTE: this implementation only accepts new_status in the range [0..9]. */
static void change_stack_tracer_status(int new_status)
{
diff --git a/trace-stat.c b/trace-stat.c
index fd16354..23d7dd4 100644
--- a/trace-stat.c
+++ b/trace-stat.c
@@ -893,6 +893,7 @@ void trace_stat (int argc, char **argv)
{
struct buffer_instance *instance = &top_instance;
int topt = 0;
+ int status;
int c;
for (;;) {
@@ -928,5 +929,12 @@ void trace_stat (int argc, char **argv)
stat_instance(instance);
}
+ if (tracecmd_stack_tracer_status(&status) >= 0) {
+ if (status > 0)
+ printf("Stack tracing is enabled\n\n");
+ } else {
+ printf("Error reading stack tracer status\n\n");
+ }
+
exit(0);
}
--
2.14.1
prev parent reply other threads:[~2018-01-16 7:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 7:47 [PATCH v3 0/3] Integrate stack tracer status in 'stat' Vladislav Valtchev (VMware)
2018-01-16 7:47 ` [PATCH v3 1/3] trace-cmd: Make read_proc() to return int status via OUT arg Vladislav Valtchev (VMware)
2018-01-16 17:19 ` Steven Rostedt
2018-01-16 19:10 ` Vladislav Valtchev
2018-01-16 19:42 ` Steven Rostedt
2018-01-16 17:30 ` Steven Rostedt
2018-01-16 7:47 ` [PATCH v3 2/3] trace-cmd: Remove the die() call from read_proc() Vladislav Valtchev (VMware)
2018-01-16 7:47 ` Vladislav Valtchev (VMware) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116074744.5522-4-vladislav.valtchev@gmail.com \
--to=vladislav.valtchev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).