From: changbin.du@intel.com
To: rostedt@goodmis.org
Cc: jolsa@redhat.com, peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org,
Changbin Du <changbin.du@intel.com>
Subject: [PATCH v3 2/3] tracing: clear parser->idx if parser gets nothing
Date: Tue, 16 Jan 2018 17:02:29 +0800 [thread overview]
Message-ID: <1516093350-12045-3-git-send-email-changbin.du@intel.com> (raw)
In-Reply-To: <1516093350-12045-1-git-send-email-changbin.du@intel.com>
From: Changbin Du <changbin.du@intel.com>
If only spaces was got in that cycle, we should clear parser->idx to make
trace_parser_loaded() return false.
Signed-off-by: Changbin Du <changbin.du@intel.com>
---
kernel/trace/trace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 144d08e..b44926e 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -1236,14 +1236,14 @@ int trace_get_user(struct trace_parser *parser, const char __user *ubuf,
cnt--;
}
+ parser->idx = 0;
+
/* only spaces were written */
if (isspace(ch) || !ch) {
*ppos += read;
ret = read;
goto out;
}
-
- parser->idx = 0;
}
/* read the non-space input */
--
2.7.4
next prev parent reply other threads:[~2018-01-16 9:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 9:02 [PATCH v3 0/3] tracing: Fix the parser when processing strings w/ or w/o terminated '\0' changbin.du
2018-01-16 9:02 ` [PATCH v3 1/3] tracing: detect the string termination character when parsing user input string changbin.du
2018-01-16 9:02 ` changbin.du [this message]
2018-01-16 9:02 ` [PATCH v3 3/3] tracing: make sure the parsed string always terminates with '\0' changbin.du
2018-01-16 17:42 ` [PATCH v3 0/3] tracing: Fix the parser when processing strings w/ or w/o terminated '\0' Steven Rostedt
2018-01-17 4:54 ` Du, Changbin
2018-01-17 5:45 ` Namhyung Kim
2018-01-17 5:47 ` Du, Changbin
2018-01-17 2:35 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516093350-12045-3-git-send-email-changbin.du@intel.com \
--to=changbin.du@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).