From: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
To: johan@kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw,
"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: [PATCH 4/5] USB: serial: f81232: implement break control
Date: Mon, 22 Jan 2018 15:58:46 +0800 [thread overview]
Message-ID: <1516607927-8887-4-git-send-email-hpeter+linux_kernel@gmail.com> (raw)
In-Reply-To: <1516607927-8887-1-git-send-email-hpeter+linux_kernel@gmail.com>
Implement Fintek F81232 break on/off with LCR register.
It's the same with 16550A LCR register layout.
Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
---
drivers/usb/serial/f81232.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/serial/f81232.c b/drivers/usb/serial/f81232.c
index dadf024ae494..a054f69446fd 100644
--- a/drivers/usb/serial/f81232.c
+++ b/drivers/usb/serial/f81232.c
@@ -377,13 +377,18 @@ static void f81232_process_read_urb(struct urb *urb)
static void f81232_break_ctl(struct tty_struct *tty, int break_state)
{
- /* FIXME - Stubbed out for now */
+ struct usb_serial_port *port = tty->driver_data;
+ struct f81232_private *priv = usb_get_serial_port_data(port);
+ int status;
- /*
- * break_state = -1 to turn on break, and 0 to turn off break
- * see drivers/char/tty_io.c to see it used.
- * last_set_data_urb_value NEVER has the break bit set in it.
- */
+ mutex_lock(&priv->lock);
+
+ status = f81232_set_mask_register(port, LINE_CONTROL_REGISTER,
+ UART_LCR_SBC, !!break_state);
+ if (status)
+ dev_err(&port->dev, "set break failed: %d\n", status);
+
+ mutex_unlock(&priv->lock);
}
static int f81232_find_clk(speed_t baudrate)
--
2.7.4
next prev parent reply other threads:[~2018-01-22 7:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 7:58 [PATCH 1/5] USB: serial: f81232: clear overrun flag Ji-Ze Hong (Peter Hong)
2018-01-22 7:58 ` [PATCH 2/5] USB: serial: f81232: add high baud rate support Ji-Ze Hong (Peter Hong)
2018-01-22 14:55 ` Andy Shevchenko
2018-01-23 2:08 ` Ji-Ze Hong (Peter Hong)
2018-01-30 3:30 ` Johan Hovold
2018-01-22 7:58 ` [PATCH 3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin Ji-Ze Hong (Peter Hong)
2018-01-30 3:57 ` Johan Hovold
2018-02-01 3:13 ` Ji-Ze Hong (Peter Hong)
2018-02-04 1:46 ` Johan Hovold
2018-02-08 9:17 ` Ji-Ze Hong (Peter Hong)
2018-01-22 7:58 ` Ji-Ze Hong (Peter Hong) [this message]
2018-01-22 7:58 ` [PATCH 5/5] USB: serial: f81232: fix bulk_in/out size Ji-Ze Hong (Peter Hong)
2018-01-30 4:11 ` Johan Hovold
2018-02-01 5:50 ` Ji-Ze Hong (Peter Hong)
2018-02-04 1:50 ` Johan Hovold
2018-01-22 10:06 ` [PATCH 1/5] USB: serial: f81232: clear overrun flag Oliver Neukum
2018-01-23 1:50 ` Ji-Ze Hong (Peter Hong)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516607927-8887-4-git-send-email-hpeter+linux_kernel@gmail.com \
--to=hpeter@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).