From: David Rientjes <rientjes@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Vladimir Davydov <vdavydov@virtuozzo.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [patch -mm] tools, vm: new option to specify kpageflags file fix fix
Date: Tue, 30 Jan 2018 18:41:08 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.10.1801301840050.140969@chino.kir.corp.google.com> (raw)
In-Reply-To: <20180130160041.ced8e9bbb4741494147f476f@linux-foundation.org>
On Tue, 30 Jan 2018, Andrew Morton wrote:
> On Tue, 30 Jan 2018 15:01:01 -0800 (PST) David Rientjes <rientjes@google.com> wrote:
>
> > page-types currently hardcodes /proc/kpageflags as the file to parse.
> > This works when using the tool to examine the state of pageflags on the
> > same system, but does not allow storing a snapshot of pageflags at a given
> > time to debug issues nor on a different system.
> >
> > This allows the user to specify a saved version of kpageflags with a new
> > page-types -F option.
> >
>
> This, methinks:
>
> --- a/tools/vm/page-types.c~tools-vm-new-option-to-specify-kpageflags-file-fix
> +++ a/tools/vm/page-types.c
> @@ -791,7 +791,7 @@ static void usage(void)
> " -N|--no-summary Don't show summary info\n"
> " -X|--hwpoison hwpoison pages\n"
> " -x|--unpoison unpoison pages\n"
> -" -F|--kpageflags kpageflags file to parse\n"
> +" -F|--kpageflags filename kpageflags file to parse\n"
> " -h|--help Show this usage message\n"
> "flags:\n"
> " 0x10 bitfield format, e.g.\n"
Please find a "fix fix" below per Naoya. Thanks both!
diff --git a/tools/vm/page-types.c b/tools/vm/page-types.c
--- a/tools/vm/page-types.c
+++ b/tools/vm/page-types.c
@@ -169,10 +169,10 @@ static int opt_raw; /* for kernel developers */
static int opt_list; /* list pages (in ranges) */
static int opt_no_summary; /* don't show summary */
static pid_t opt_pid; /* process to walk */
-const char * opt_file; /* file or directory path */
+const char *opt_file; /* file or directory path */
static uint64_t opt_cgroup; /* cgroup inode */
static int opt_list_cgroup;/* list page cgroup */
-static const char * opt_kpageflags; /* kpageflags file to parse */
+static const char *opt_kpageflags;/* kpageflags file to parse */
#define MAX_ADDR_RANGES 1024
static int nr_addr_ranges;
next prev parent reply other threads:[~2018-01-31 2:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 23:01 [patch] tools, vm: new option to specify kpageflags file David Rientjes
2018-01-31 0:00 ` Andrew Morton
2018-01-31 2:41 ` David Rientjes [this message]
2018-01-31 2:01 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1801301840050.140969@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).