platform/mellanox: mlxreg-hotplug: Fix uninitialized variable
diff mbox series

Message ID 1517994724-5931-1-git-send-email-geert@linux-m68k.org
State New, archived
Headers show
Series
  • platform/mellanox: mlxreg-hotplug: Fix uninitialized variable
Related show

Commit Message

Geert Uytterhoeven Feb. 7, 2018, 9:12 a.m. UTC
With gcc-4.1.2:

    drivers/platform/mellanox/mlxreg-hotplug.c: In function ‘mlxreg_hotplug_health_work_helper’:
    drivers/platform/mellanox/mlxreg-hotplug.c:347: warning: ‘ret’ is used uninitialized in this function

Indeed, if mlxreg_core_item.count is zero, ret is used uninitialized.

While this is unlikely to happen (it is set to ARRAY_SIZE(...) in x86
board files), this is done in another source file, so fix this by
preinitializing ret to zero.

Fixes: c6acad68eb2dbffd ("platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/platform/mellanox/mlxreg-hotplug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Vadim Pasternak Feb. 7, 2018, 9:39 a.m. UTC | #1
> -----Original Message-----
> From: Geert Uytterhoeven [mailto:geert@linux-m68k.org]
> Sent: Wednesday, February 07, 2018 11:12 AM
> To: Andy Shevchenko <andy@infradead.org>; Darren Hart
> <dvhart@infradead.org>; Vadim Pasternak <vadimp@mellanox.com>
> Cc: Arnd Bergmann <arnd@arndb.de>; platform-driver-x86@vger.kernel.org;
> linux-kernel@vger.kernel.org; Geert Uytterhoeven <geert@linux-m68k.org>
> Subject: [PATCH] platform/mellanox: mlxreg-hotplug: Fix uninitialized variable
> 
> With gcc-4.1.2:
> 
>     drivers/platform/mellanox/mlxreg-hotplug.c: In function
> ‘mlxreg_hotplug_health_work_helper’:
>     drivers/platform/mellanox/mlxreg-hotplug.c:347: warning: ‘ret’ is used
> uninitialized in this function
> 
> Indeed, if mlxreg_core_item.count is zero, ret is used uninitialized.
> 
> While this is unlikely to happen (it is set to ARRAY_SIZE(...) in x86 board files),
> this is done in another source file, so fix this by preinitializing ret to zero.
> 
> Fixes: c6acad68eb2dbffd ("platform/mellanox: mlxreg-hotplug: Modify to use a
> regmap interface")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: Vadim Pasternak <vadimp@mellanox.com>

> ---
>  drivers/platform/mellanox/mlxreg-hotplug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c
> b/drivers/platform/mellanox/mlxreg-hotplug.c
> index 0dfa1ca0d05b0217..313cf8ad77bf68ce 100644
> --- a/drivers/platform/mellanox/mlxreg-hotplug.c
> +++ b/drivers/platform/mellanox/mlxreg-hotplug.c
> @@ -300,7 +300,7 @@ mlxreg_hotplug_health_work_helper(struct
> mlxreg_hotplug_priv_data *priv,  {
>  	struct mlxreg_core_data *data = item->data;
>  	u32 regval;
> -	int i, ret;
> +	int i, ret = 0;
> 
>  	for (i = 0; i < item->count; i++, data++) {
>  		/* Mask event. */
> --
> 2.7.4

Patch
diff mbox series

diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c b/drivers/platform/mellanox/mlxreg-hotplug.c
index 0dfa1ca0d05b0217..313cf8ad77bf68ce 100644
--- a/drivers/platform/mellanox/mlxreg-hotplug.c
+++ b/drivers/platform/mellanox/mlxreg-hotplug.c
@@ -300,7 +300,7 @@  mlxreg_hotplug_health_work_helper(struct mlxreg_hotplug_priv_data *priv,
 {
 	struct mlxreg_core_data *data = item->data;
 	u32 regval;
-	int i, ret;
+	int i, ret = 0;
 
 	for (i = 0; i < item->count; i++, data++) {
 		/* Mask event. */