From: Anton Blanchard <anton@linuxcare.com.au>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] pcnet32 one liner
Date: Sun, 14 Jan 2001 10:49:11 +1100 [thread overview]
Message-ID: <20010114104911.C20398@linuxcare.com> (raw)
Hi,
The code below is suspect.
Anton
diff -r -u --new-file --exclude-from=/home/anton/kernel/exclude linux/drivers/net/pcnet32.c linux_work/drivers/net/pcnet32.c
--- linux/drivers/net/pcnet32.c Tue Dec 12 14:27:56 2000
+++ linux_work/drivers/net/pcnet32.c Tue Jan 9 15:12:20 2001
@@ -809,7 +809,7 @@
val |= 0x10;
lp->a.write_csr (ioaddr, 124, val);
- if (lp->mii & !(lp->options & PORT_ASEL)) {
+ if (lp->mii && !(lp->options & PORT_ASEL)) {
val = lp->a.read_bcr (ioaddr, 32) & ~0x38; /* disable Auto Negotiation, set 10Mpbs, HD */
if (lp->options & PORT_FD)
val |= 0x10;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
reply other threads:[~2001-01-13 23:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010114104911.C20398@linuxcare.com \
--to=anton@linuxcare.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).