linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: linux-rtc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: [PATCH 004/100] rtc: rs5c348: let the core handle invalid time
Date: Wed, 21 Feb 2018 21:54:59 +0100	[thread overview]
Message-ID: <20180221205635.31314-5-alexandre.belloni@bootlin.com> (raw)
In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com>

Returning a valid time when the time is invalid is a bad practice, because
then userspace is not able to react on the information. Also, it doesn't
make sense to return epoch because it is already the default time.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
 drivers/rtc/rtc-rs5c348.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/rtc/rtc-rs5c348.c b/drivers/rtc/rtc-rs5c348.c
index 9a306983aaba..f2de8b17e7e3 100644
--- a/drivers/rtc/rtc-rs5c348.c
+++ b/drivers/rtc/rtc-rs5c348.c
@@ -135,11 +135,6 @@ rs5c348_rtc_read_time(struct device *dev, struct rtc_time *tm)
 	tm->tm_year = bcd2bin(rxbuf[RS5C348_REG_YEAR]) +
 		((rxbuf[RS5C348_REG_MONTH] & RS5C348_BIT_Y2K) ? 100 : 0);
 
-	if (rtc_valid_tm(tm) < 0) {
-		dev_err(&spi->dev, "retrieved date/time is not valid.\n");
-		rtc_time_to_tm(0, tm);
-	}
-
 	return 0;
 }
 
-- 
2.16.1

  parent reply	other threads:[~2018-02-21 21:23 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-21 20:54 [PATCH 000/100] rtc: remove cargo culted code Alexandre Belloni
2018-02-21 20:54 ` [PATCH 001/100] rtc: ds1511: let the core handle invalid time Alexandre Belloni
2018-02-21 20:54 ` [PATCH 002/100] rtc: ds1553: " Alexandre Belloni
2018-02-21 20:54 ` [PATCH 003/100] rtc: cmos: " Alexandre Belloni
2018-02-21 20:54 ` Alexandre Belloni [this message]
2018-02-21 20:55 ` [PATCH 005/100] rtc: stk17ta8: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 006/100] rtc: ab-b5ze-s3: stop validating rtc_time in .read_time Alexandre Belloni
2018-02-21 20:55 ` [PATCH 007/100] rtc: ab3100: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 008/100] rtc: ab8500: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 009/100] rtc: ac100: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 010/100] rtc: au1xxx: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 011/100] rtc: bq32k: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 012/100] rtc: coh901331: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 013/100] rtc: cpcap: " Alexandre Belloni
2018-02-22 11:40   ` Sebastian Reichel
2018-02-21 20:55 ` [PATCH 014/100] rtc: da9052: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 015/100] rtc: da9055: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 016/100] rtc: da9063: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 017/100] rtc: ds1216: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 018/100] rtc: ds1286: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 019/100] rtc: ds1302: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 020/100] rtc: ds1305: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 021/100] rtc: ds1307: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 022/100] rtc: ds1343: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 023/100] rtc: ds1347: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 024/100] rtc: ds1390: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 025/100] rtc: ds1685: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 026/100] rtc: ds1742: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 027/100] rtc: ds2404: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 028/100] rtc: ds3232: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 029/100] rtc: efi: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 030/100] rtc: fm3130: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 031/100] rtc: jz4740: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 032/100] rtc: lpc24xx: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 033/100] rtc: lpc32xx: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 034/100] rtc: ls1x: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 035/100] rtc: m41t94: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 036/100] rtc: m48t35: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 037/100] rtc: m48t59: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 038/100] rtc: m48t86: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 039/100] rtc: max6902: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 040/100] rtc: max6916: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 041/100] rtc: max8997: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 042/100] rtc: max8998: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 043/100] rtc: mc13xxx: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 044/100] rtc: mcp795: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 045/100] rtc: mpc5121: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 046/100] rtc: mrst: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 047/100] rtc: msm6242: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 048/100] rtc: mt7622: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 049/100] rtc: mv: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 050/100] rtc: nuc900: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 051/100] rtc: pcap: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 052/100] rtc: pcf2123: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 053/100] rtc: pcf2127: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 054/100] rtc: pcf50633: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 055/100] rtc: pcf8523: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 056/100] rtc: pic32: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 057/100] rtc: ps3: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 058/100] rtc: r7301: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 059/100] rtc: r9701: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 060/100] rtc: rp5c01: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 061/100] rtc: rx6110: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 062/100] rtc: rx8010: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 063/100] rtc: rx8025: " Alexandre Belloni
2018-02-21 20:55 ` [PATCH 064/100] rtc: s3c: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 065/100] rtc: s5m: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 066/100] rtc: sc27xx: " Alexandre Belloni
2018-02-22  1:53   ` Baolin Wang
2018-02-21 20:56 ` [PATCH 067/100] rtc: sh: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 068/100] rtc: starfire: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 069/100] rtc: sun6i: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 070/100] rtc: sunxi: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 071/100] rtc: tps6586x: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 072/100] rtc: tx4939: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 073/100] rtc: wm831x: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 074/100] rtc: xgene: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 075/100] rtc: zynqmp: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 076/100] rtc: isl12022: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 077/100] rtc: isl12022: remove useless indirection Alexandre Belloni
2018-02-21 20:56 ` [PATCH 078/100] rtc: m41t80: stop validating rtc_time in .read_time Alexandre Belloni
2018-02-21 20:56 ` [PATCH 079/100] rtc: m41t93: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 080/100] rtc: max77686: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 081/100] rtc: omap: stop validating rtc_time in .set_time and .set_alarm Alexandre Belloni
2018-02-21 20:56 ` [PATCH 082/100] rtc: spear: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 083/100] rtc: tegra: stop validating rtc_time in .set_time Alexandre Belloni
2018-02-21 20:56 ` [PATCH 084/100] rtc: abx80x: remove useless message Alexandre Belloni
2018-02-21 20:56 ` [PATCH 085/100] rtc: pm8xxx: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 086/100] rtc: rx4581: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 087/100] rtc: rx8581: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 088/100] rtc: tile: " Alexandre Belloni
2018-02-21 20:56 ` [PATCH 089/100] rtc: rk808: remove useless debug message Alexandre Belloni
2018-02-21 20:56 ` [PATCH 090/100] rtc: rk808: fix possible race condition Alexandre Belloni
2018-02-21 20:56 ` [PATCH 091/100] rtc: s35390a: remove useless message Alexandre Belloni
2018-02-21 20:56 ` [PATCH 092/100] rtc: s35390a: stop validating rtc_time in .read_time Alexandre Belloni
2018-02-21 20:56 ` [PATCH 093/100] rtc: s35390a: remove useless indirection Alexandre Belloni
2018-02-21 20:56 ` [PATCH 094/100] rtc: rs5c372: remove useless message Alexandre Belloni
2018-02-21 20:56 ` [PATCH 095/100] rtc: rs5c372: stop validating rtc_time in .read_time Alexandre Belloni
2018-02-21 20:56 ` [PATCH 096/100] rtc: rs5c372: remove useless indirection Alexandre Belloni
2018-02-21 20:56 ` [PATCH 097/100] rtc: max6900: stop validating rtc_time in .read_time Alexandre Belloni
2018-02-21 20:56 ` [PATCH 098/100] rtc: max6900: remove useless indirection Alexandre Belloni
2018-02-21 20:56 ` [PATCH 099/100] rtc: pcf85063: stop validating rtc_time in .read_time Alexandre Belloni
2018-02-21 20:56 ` [PATCH 100/100] rtc: pcf85063: remove useless indirection Alexandre Belloni
2018-02-22 15:48 ` [PATCH 000/100] rtc: remove cargo culted code Christoph Hellwig
2018-02-22 16:02   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180221205635.31314-5-alexandre.belloni@bootlin.com \
    --to=alexandre.belloni@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).