From: Nick Desaulniers <ndesaulniers@google.com>
To: akpm@linux-foundation.org, ard.biesheuvel@linaro.org,
aryabinin@virtuozzo.com, akataria@vmware.com,
boris.ostrovsky@oracle.com, brijesh.singh@amd.com,
caoj.fnst@cn.fujitsu.com, gregkh@linuxfoundation.org,
hpa@zytor.com, jan.kiszka@siemens.com,
jarkko.sakkinen@linux.intel.com, jgross@suse.com,
jpoimboe@redhat.com, kirill.shutemov@linux.intel.com,
mingo@redhat.com, mjg59@google.com, mka@chromium.org,
ndesaulniers@google.com, pombredanne@nexb.com,
rostedt@goodmis.org, tglx@linutronix.de, thomas.lendacky@amd.com,
tweek@google.com
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, virtualization@lists.linux-foundation.org
Subject: [PATCH 2/3] x86/build: use -std=gnu89 for proper extern inline semantics
Date: Fri, 1 Jun 2018 09:55:49 -0700 [thread overview]
Message-ID: <20180601165550.90053-3-ndesaulniers@google.com> (raw)
In-Reply-To: <20180601165550.90053-1-ndesaulniers@google.com>
The top level Makefile explicitly sets the C standard used in the kernel
to gnu89. By overriding KBUILD_CFLAGS, the C standard used for this
subdir is now implicit based on compiler and compiler version. GCC
changes this implicit default from gnu89 to gnu11 in v5.1.
This implies that depending on compiler version, parts of the kernel are
being linked together from object files that were compiled with
different C standard compiler flags.
This is problematic for symbols declared as extern inline, as the
semantics have switched since gnu89. See also:
http://blahg.josefsipek.net/?p=529
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
---
arch/x86/boot/compressed/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
index fa42f895fdde..1a04c7e9add1 100644
--- a/arch/x86/boot/compressed/Makefile
+++ b/arch/x86/boot/compressed/Makefile
@@ -26,7 +26,7 @@ KCOV_INSTRUMENT := n
targets := vmlinux vmlinux.bin vmlinux.bin.gz vmlinux.bin.bz2 vmlinux.bin.lzma \
vmlinux.bin.xz vmlinux.bin.lzo vmlinux.bin.lz4
-KBUILD_CFLAGS := -m$(BITS) -O2
+KBUILD_CFLAGS := -m$(BITS) -O2 -std=gnu89
KBUILD_CFLAGS += -fno-strict-aliasing $(call cc-option, -fPIE, -fPIC)
KBUILD_CFLAGS += -DDISABLE_BRANCH_PROFILING
cflags-$(CONFIG_X86_32) := -march=i386
--
2.17.0.921.gf22659ad46-goog
next prev parent reply other threads:[~2018-06-01 16:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 16:55 [PATCH 0/3] extern inline native_save_fl for paravirt Nick Desaulniers
2018-06-01 16:55 ` [PATCH 1/3] efi: use -std=gnu89 for proper extern inline semantics Nick Desaulniers
2018-06-01 16:55 ` Nick Desaulniers [this message]
2018-06-01 17:36 ` [PATCH 2/3] x86/build: " hpa
2018-06-01 16:55 ` [PATCH 3/3] x86: paravirt: make native_save_fl extern inline Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601165550.90053-3-ndesaulniers@google.com \
--to=ndesaulniers@google.com \
--cc=akataria@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=aryabinin@virtuozzo.com \
--cc=boris.ostrovsky@oracle.com \
--cc=brijesh.singh@amd.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgross@suse.com \
--cc=jpoimboe@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mjg59@google.com \
--cc=mka@chromium.org \
--cc=pombredanne@nexb.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tweek@google.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).