From: SF Markus Elfring <elfring@users.sourceforge.net>
To: kernel-janitors@vger.kernel.org, Lee Jones <lee.jones@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 04/17] mfd: si476x-i2c: Delete an error message for a failed memory allocation in si476x_core_probe()
Date: Fri, 9 Mar 2018 17:07:16 +0100 [thread overview]
Message-ID: <77d99255-820d-1152-0c5c-88d8cd2f26ab@users.sourceforge.net> (raw)
In-Reply-To: <c5d9751e-3ae8-0b66-821a-0e7f45bb8e1c@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 8 Mar 2018 13:45:31 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
v2:
Lee Jones requested a resend for this patch. The change was rebased
on source files from Linux next-20180308.
drivers/mfd/si476x-i2c.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/si476x-i2c.c b/drivers/mfd/si476x-i2c.c
index e6a3d999a376..2c5ec93333c3 100644
--- a/drivers/mfd/si476x-i2c.c
+++ b/drivers/mfd/si476x-i2c.c
@@ -697,11 +697,9 @@ static int si476x_core_probe(struct i2c_client *client,
int cell_num;
core = devm_kzalloc(&client->dev, sizeof(*core), GFP_KERNEL);
- if (!core) {
- dev_err(&client->dev,
- "failed to allocate 'struct si476x_core'\n");
+ if (!core)
return -ENOMEM;
- }
+
core->client = client;
core->regmap = devm_regmap_init_si476x(core);
--
2.16.2
next prev parent reply other threads:[~2018-03-09 16:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 15:55 [PATCH v2 00/17] MFD: Adjustments for several function implementations SF Markus Elfring
2018-03-09 16:00 ` [PATCH v2 0/3] mfd/abx500-core: Adjustments for eight " SF Markus Elfring
2018-03-09 16:01 ` [PATCH v2 01/17 1/3] mfd: abx500-core: Delete an error message for a failed memory allocation in abx500_register_ops() SF Markus Elfring
2018-03-09 16:02 ` [PATCH v2 02/17 2/3] mfd: abx500-core: Improve two size determinations " SF Markus Elfring
2018-03-09 16:03 ` [PATCH v2 03/17 3/3] mfd: abx500-core: Adjust 14 checks for null pointers SF Markus Elfring
2018-03-24 14:25 ` [PATCH v2 0/3] mfd/abx500-core: Adjustments for eight function implementations Linus Walleij
2018-03-09 16:07 ` SF Markus Elfring [this message]
2018-03-09 16:10 ` [PATCH v2 0/2] mfd/sm501: Adjustments for five " SF Markus Elfring
2018-03-09 16:12 ` [PATCH v2 05/17 1/2] mfd: sm501: Improve a size determination in two functions SF Markus Elfring
2018-03-09 16:13 ` [PATCH v2 06/17 2/2] mfd: sm501: Adjust 12 checks for null pointers SF Markus Elfring
2018-03-09 16:17 ` [PATCH v2 07/17] mfd: smsc-ece1099: Improve a size determination in smsc_i2c_probe() SF Markus Elfring
2018-03-09 16:18 ` [PATCH v2 08/17] mfd: ti_am335x_tscadc: Delete an error message for a failed memory allocation in ti_tscadc_probe() SF Markus Elfring
2018-03-09 16:20 ` [PATCH v2 09/17] mfd: tps65090: Delete an error message for a failed memory allocation in tps65090_i2c_probe() SF Markus Elfring
2018-03-09 16:22 ` [PATCH v2 10/17] mfd: tps6586x: Delete an error message for a failed memory allocation in tps6586x_parse_dt() SF Markus Elfring
2018-03-09 16:24 ` [PATCH v2 0/4] mfd/tps65910: Adjustments for four function implementations SF Markus Elfring
2018-03-09 16:28 ` [PATCH v2 11/17] mfd: tps65910: Delete an error message for a failed memory allocation in tps65910_parse_dt() SF Markus Elfring
2018-03-09 16:37 ` [PATCH v2 12/17 2/4] mfd: tps65910: Delete an unnecessary variable initialisation in four functions SF Markus Elfring
2018-03-09 16:39 ` [PATCH v2 13/17 3/4] mfd: tps65910: Delete an unnecessary variable initialisation in tps65910_sleepinit() SF Markus Elfring
2018-03-09 16:42 ` [PATCH v2 14/17 4/4] mfd: tps65910: Move an assignment " SF Markus Elfring
2018-03-12 8:57 ` Lee Jones
2018-03-13 7:14 ` [v2 14/17 4/4] mfd: tps65910: Checking patch structures SF Markus Elfring
2018-03-13 7:56 ` Lee Jones
2018-03-09 16:46 ` [PATCH v2 15/17] mfd: tps80031: Delete an error message for a failed memory allocation in tps80031_probe() SF Markus Elfring
2018-03-09 16:49 ` [PATCH v2 16/17] mfd: twl6030-irq: Delete an error message for a failed memory allocation in twl6030_init_irq() SF Markus Elfring
2018-03-09 16:50 ` [PATCH v2 17/17] mfd: viperboard: Delete an error message for a failed memory allocation in vprbrd_probe() SF Markus Elfring
2018-03-27 8:03 ` [PATCH v2 00/17] MFD: Adjustments for several function implementations Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77d99255-820d-1152-0c5c-88d8cd2f26ab@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).