linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Streetman <ddstreet@ieee.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Josh Triplett <josh@joshtriplett.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Lai Jiangshan <laijs@cn.fujitsu.com>,
	linux-kernel@vger.kernel.org, Dan Streetman <ddstreet@ieee.org>
Subject: [PATCH 1/2] rcu: introduce list_last_or_null_rcu
Date: Thu, 28 May 2015 16:35:27 -0400	[thread overview]
Message-ID: <1432845328-27932-1-git-send-email-ddstreet@ieee.org> (raw)

Add list_last_or_null_rcu(), to simplify getting the last entry from a
rcu-protected list.  The standard list_last_entry() can't be used as it
is not rcu-protected; the list may be modified concurrently.  And the
->prev pointer can't be used, as only the ->next pointers are protected
by rcu.

This simply iterates forward through the entire list, to get to the last
entry.  If the list is empty, it returns NULL.

Signed-off-by: Dan Streetman <ddstreet@ieee.org>
---
 include/linux/rculist.h | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/include/linux/rculist.h b/include/linux/rculist.h
index a18b16f..954fde5 100644
--- a/include/linux/rculist.h
+++ b/include/linux/rculist.h
@@ -293,6 +293,27 @@ static inline void list_splice_init_rcu(struct list_head *list,
 })
 
 /**
+ * list_last_or_null_rcu - get the last element from a list
+ * @ptr:        the list head to take the element from.
+ * @type:       the type of the struct this is embedded in.
+ * @member:     the name of the list_head within the struct.
+ *
+ * Note that if the list is empty, it returns NULL.
+ *
+ * This primitive may safely run concurrently with the _rcu list-mutation
+ * primitives such as list_add_rcu() as long as it's guarded by rcu_read_lock().
+ */
+#define list_last_or_null_rcu(ptr, type, member) \
+({ \
+	struct list_head *__ptr = (ptr); \
+	struct list_head *__last = __ptr; \
+	struct list_head *__entry = list_next_rcu(__ptr); \
+	for (; __entry != __ptr; __entry = list_next_rcu(__entry)) \
+		__last = __entry; \
+	likely(__ptr != __last) ? list_entry_rcu(__last, type, member) : NULL; \
+})
+
+/**
  * list_for_each_entry_rcu	-	iterate over rcu list of given type
  * @pos:	the type * to use as a loop cursor.
  * @head:	the head for your list.
-- 
2.1.0


             reply	other threads:[~2015-05-28 20:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28 20:35 Dan Streetman [this message]
2015-05-28 20:36 ` [PATCH 2/2] list: introduce list_last_entry_or_null Dan Streetman
2015-05-28 20:39 ` [PATCH 1/2] rcu: introduce list_last_or_null_rcu josh
2015-05-28 20:42   ` Dan Streetman
2015-05-28 20:44     ` Dan Streetman
2015-05-28 21:06       ` Paul E. McKenney
2015-05-28 21:10       ` josh
2015-05-28 21:05     ` Paul E. McKenney
2015-05-28 21:14       ` Dan Streetman
2015-05-28 21:17         ` Paul E. McKenney
2015-05-28 21:19           ` Dan Streetman
2015-05-28 21:28             ` Steven Rostedt
2015-05-28 21:30               ` Dan Streetman
2015-05-28 21:33                 ` Dan Streetman
2015-05-28 21:05 ` Steven Rostedt
2015-05-28 21:12   ` Dan Streetman
2015-05-28 21:16     ` Paul E. McKenney
2015-05-28 21:24       ` Dan Streetman
2015-05-28 22:29         ` Paul E. McKenney
2015-05-28 23:22           ` Dan Streetman
2015-05-29 13:40           ` Dan Streetman
2015-06-01 18:17             ` Paul E. McKenney
2015-06-01 22:11               ` Dan Streetman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432845328-27932-1-git-send-email-ddstreet@ieee.org \
    --to=ddstreet@ieee.org \
    --cc=akpm@linux-foundation.org \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).