From: st6589@public-files.de
To: linux-kernel@vger.kernel.org
Cc: linux-amlogic@lists.infradead.org
Subject: [BUG] Pinning in pinctrl-meson-gxbb.c for uart_C is wrong
Date: Mon, 11 Jun 2018 12:01:43 +0200 [thread overview]
Message-ID: <trinity-5eab4708-85af-4a10-911f-86b9afc2c0cc-1528711303734@3c-app-gmx-bs27> (raw)
[-- Attachment #1: Type: text/plain, Size: 1869 bytes --]
Hello with the actuel Pinning definition in pinctrl-meson-gxbb.c for the uart_c
the system crashes when activated. The seams to be a depency with mmc driver for SD cards.
according to the comment here: https://forum.odroid.com/viewtopic.php?f=137&t=25373#p177855
the seams to be an error in the amlogic datasheets regarding uart_c
with the attached patch everything works as it should.
Best regards
##
# https://forum.odroid.com/viewtopic.php?f=137&t=25373#p177855
#
--- linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c.orig 2018-06-09 12:03:58.921540445 +0200
+++ linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c 2018-06-10 18:51:52.080665271 +0200
@@ -198,8 +198,8 @@
static const unsigned int uart_tx_c_pins[] = { GPIOY_13 };
static const unsigned int uart_rx_c_pins[] = { GPIOY_14 };
-static const unsigned int uart_cts_c_pins[] = { GPIOX_11 };
-static const unsigned int uart_rts_c_pins[] = { GPIOX_12 };
+static const unsigned int uart_cts_c_pins[] = { GPIOY_11 };
+static const unsigned int uart_rts_c_pins[] = { GPIOY_12 };
static const unsigned int i2c_sck_a_pins[] = { GPIODV_25 };
static const unsigned int i2c_sda_a_pins[] = { GPIODV_24 };
@@ -443,10 +443,10 @@
GROUP(pwm_f_x, 3, 18),
/* Bank Y */
- GROUP(uart_cts_c, 1, 19),
- GROUP(uart_rts_c, 1, 18),
- GROUP(uart_tx_c, 1, 17),
- GROUP(uart_rx_c, 1, 16),
+ GROUP(uart_cts_c, 1, 17),
+ GROUP(uart_rts_c, 1, 16),
+ GROUP(uart_tx_c, 1, 19),
+ GROUP(uart_rx_c, 1, 18),
GROUP(pwm_a_y, 1, 21),
GROUP(pwm_f_y, 1, 20),
GROUP(i2s_out_ch23_y, 1, 5),
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: my-diff-4.17-uac-pin.diff --]
[-- Type: text/x-patch, Size: 1160 bytes --]
##
# https://forum.odroid.com/viewtopic.php?f=137&t=25373#p177855
#
--- linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c.orig 2018-06-09 12:03:58.921540445 +0200
+++ linux-next-20180608/drivers/pinctrl/meson/pinctrl-meson-gxbb.c 2018-06-10 18:51:52.080665271 +0200
@@ -198,8 +198,8 @@
static const unsigned int uart_tx_c_pins[] = { GPIOY_13 };
static const unsigned int uart_rx_c_pins[] = { GPIOY_14 };
-static const unsigned int uart_cts_c_pins[] = { GPIOX_11 };
-static const unsigned int uart_rts_c_pins[] = { GPIOX_12 };
+static const unsigned int uart_cts_c_pins[] = { GPIOY_11 };
+static const unsigned int uart_rts_c_pins[] = { GPIOY_12 };
static const unsigned int i2c_sck_a_pins[] = { GPIODV_25 };
static const unsigned int i2c_sda_a_pins[] = { GPIODV_24 };
@@ -443,10 +443,10 @@
GROUP(pwm_f_x, 3, 18),
/* Bank Y */
- GROUP(uart_cts_c, 1, 19),
- GROUP(uart_rts_c, 1, 18),
- GROUP(uart_tx_c, 1, 17),
- GROUP(uart_rx_c, 1, 16),
+ GROUP(uart_cts_c, 1, 17),
+ GROUP(uart_rts_c, 1, 16),
+ GROUP(uart_tx_c, 1, 19),
+ GROUP(uart_rx_c, 1, 18),
GROUP(pwm_a_y, 1, 21),
GROUP(pwm_f_y, 1, 20),
GROUP(i2s_out_ch23_y, 1, 5),
next reply other threads:[~2018-06-11 10:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 10:01 st6589 [this message]
2018-06-11 11:35 ` [BUG] Pinning in pinctrl-meson-gxbb.c for uart_C is wrong Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=trinity-5eab4708-85af-4a10-911f-86b9afc2c0cc-1528711303734@3c-app-gmx-bs27 \
--to=st6589@public-files.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).