From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [x86 patch] Fix UML init/do_mounts.h build failure
Date: Thu, 25 Oct 2007 16:23:32 +0530 [thread overview]
Message-ID: <20071025105332.18472.58436.sendpatchset@balbir-laptop> (raw)
Fix stat.h to not use __i386__, but use BITS_PER_LONG. The UML architecture
in turn includes this file. This helps resolve one build failure in the
current UML code
Before the fix, the failure was
In file included from init/do_mounts.c:19:
init/do_mounts.h: In function 'bstat':
init/do_mounts.h:25: error: storage size of 'stat' isn't known
init/do_mounts.h:25: warning: unused variable 'stat'
init/do_mounts.h:33: warning: control reaches end of non-void function
make[1]: *** [init/do_mounts.o] Error 1
make: *** [init/do_mounts.o] Error 2
Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
---
include/asm-x86/stat.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff -puN init/do_mounts.h~uml-fix-init-domounts init/do_mounts.h
diff -puN include/asm-x86/stat.h~uml-fix-init-domounts include/asm-x86/stat.h
--- 2.6.24-rc1/include/asm-x86/stat.h~uml-fix-init-domounts 2007-10-25 16:23:04.000000000 +0530
+++ 2.6.24-rc1-balbir/include/asm-x86/stat.h 2007-10-25 16:23:04.000000000 +0530
@@ -1,9 +1,11 @@
#ifndef _ASM_X86_STAT_H
#define _ASM_X86_STAT_H
+#include <asm/types.h>
+
#define STAT_HAVE_NSEC 1
-#ifdef __i386__
+#if BITS_PER_LONG == 32
struct stat {
unsigned long st_dev;
unsigned long st_ino;
@@ -63,7 +65,7 @@ struct stat64 {
unsigned long long st_ino;
};
-#else /* __i386__ */
+#else /* BITS_PER_LONG == 32 */
struct stat {
unsigned long st_dev;
_
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
next reply other threads:[~2007-10-25 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 10:53 Balbir Singh [this message]
2007-10-25 11:36 [x86 patch] Fix UML init/do_mounts.h build failure Balbir Singh
2007-10-27 3:21 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071025105332.18472.58436.sendpatchset@balbir-laptop \
--to=balbir@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).