From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Guenter Roeck <linux@roeck-us.net>, Hans de Goede <hdegoede@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jun Li <jun.li@nxp.com>, Mats Karrman <mats.dev.list@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH v4 7/8] usb: typec: pi3usb30532: Start using generic state values
Date: Fri, 8 Jun 2018 14:29:40 +0300 [thread overview]
Message-ID: <20180608112941.26332-8-heikki.krogerus@linux.intel.com> (raw)
In-Reply-To: <20180608112941.26332-1-heikki.krogerus@linux.intel.com>
Instead of the tcpm specific mux states, using the generic
USB type-c connector state values, and with DisplayPort
using connector states defined for the DisplayPort Alt Mode.
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
drivers/usb/typec/mux/pi3usb30532.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/typec/mux/pi3usb30532.c b/drivers/usb/typec/mux/pi3usb30532.c
index b0e88db60ecf..bcea242852f2 100644
--- a/drivers/usb/typec/mux/pi3usb30532.c
+++ b/drivers/usb/typec/mux/pi3usb30532.c
@@ -9,7 +9,7 @@
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/mutex.h>
-#include <linux/usb/tcpm.h>
+#include <linux/usb/typec_dp.h>
#include <linux/usb/typec_mux.h>
#define PI3USB30532_CONF 0x00
@@ -83,21 +83,24 @@ static int pi3usb30532_mux_set(struct typec_mux *mux, int state)
new_conf = pi->conf;
switch (state) {
- case TYPEC_MUX_NONE:
+ case TYPEC_STATE_SAFE:
new_conf = PI3USB30532_CONF_OPEN;
break;
- case TYPEC_MUX_USB:
+ case TYPEC_STATE_USB:
new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
- PI3USB30532_CONF_USB3;
+ PI3USB30532_CONF_USB3;
break;
- case TYPEC_MUX_DP:
+ case TYPEC_DP_STATE_C:
+ case TYPEC_DP_STATE_E:
new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
PI3USB30532_CONF_4LANE_DP;
break;
- case TYPEC_MUX_DOCK:
+ case TYPEC_DP_STATE_D:
new_conf = (new_conf & PI3USB30532_CONF_SWAP) |
PI3USB30532_CONF_USB3_AND_2LANE_DP;
break;
+ default:
+ break;
}
ret = pi3usb30532_set_conf(pi, new_conf);
--
2.17.1
next prev parent reply other threads:[~2018-06-08 11:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 11:29 [RFC PATCH v4 0/8] usb: typec: Support for Alternate Modes Heikki Krogerus
2018-06-08 11:29 ` [RFC PATCH v4 1/8] usb: pd: include kernel.h Heikki Krogerus
2018-06-11 7:08 ` Greg Kroah-Hartman
2018-06-11 8:51 ` Heikki Krogerus
2018-06-08 11:29 ` [RFC PATCH v4 2/8] usb: typec: helper for checking cable plug orientation Heikki Krogerus
2018-06-12 18:56 ` Mats Karrman
2018-06-12 22:18 ` Guenter Roeck
2018-06-13 12:33 ` Heikki Krogerus
2018-06-08 11:29 ` [RFC PATCH v4 3/8] usb: typec: mux: Get the mux identifier from function parameter Heikki Krogerus
2018-06-08 11:29 ` [RFC PATCH v4 4/8] usb: typec: Register a device for every mode Heikki Krogerus
2018-06-08 11:29 ` [RFC PATCH v4 5/8] usb: typec: Bus type for alternate modes Heikki Krogerus
2018-06-08 11:29 ` [RFC PATCH v4 6/8] usb: typec: Add driver for DisplayPort alternate mode Heikki Krogerus
2018-06-08 14:04 ` Heikki Krogerus
2018-06-08 11:29 ` Heikki Krogerus [this message]
2018-06-08 17:51 ` [RFC PATCH v4 7/8] usb: typec: pi3usb30532: Start using generic state values Sergei Shtylyov
2018-06-08 11:29 ` [RFC PATCH v4 8/8] usb: typec: tcpm: Support for Alternate Modes Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608112941.26332-8-heikki.krogerus@linux.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jun.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mats.dev.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).